All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Alex Bligh <alex@alex.org.uk>
Cc: "Kevin Wolf" <kwolf@redhat.com>,
	"Liu Ping Fan" <pingfank@linux.vnet.ibm.com>,
	"Anthony Liguori" <anthony@codemonkey.ws>,
	"Stefan Hajnoczi" <stefanha@gmail.com>,
	"Jeff Cody" <jcody@redhat.com>,
	"Michael Tokarev" <mjt@tls.msk.ru>,
	qemu-devel@nongnu.org, "Markus Armbruster" <armbru@redhat.com>,
	malc <av1474@comtv.ru>, "Stefan Hajnoczi" <stefanha@redhat.com>,
	"Stefan Weil" <sw@weilnetz.de>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"Asias He" <asias@redhat.com>,
	"Luiz Capitulino" <lcapitulino@redhat.com>,
	"Andreas Färber" <afaerber@suse.de>,
	"Eduardo Habkost" <ehabkost@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 0/3] Make thread pool implementation modular
Date: Mon, 11 Nov 2013 19:44:33 +0100	[thread overview]
Message-ID: <52812591.3040903@redhat.com> (raw)
In-Reply-To: <70557888-4FD2-41C9-8805-2BC2DC154F07@alex.org.uk>

Il 11/11/2013 19:32, Alex Bligh ha scritto:
> 
> On 11 Nov 2013, at 18:01, Paolo Bonzini wrote:
> 
>> Il 11/11/2013 18:59, Alex Bligh ha scritto:
>>>> Why is it necessary to push this task down into the host?  I don't
>>>> understand the advantage of this approach except that maybe it works
>>>> around certain misconfigurations, I/O scheduler quirks, or plain old
>>>> bugs - all of which should be investigated and fixed at the source
>>>> instead of adding another layer of code to mask them.
>>>
>>> I can see an argument why a guest with two very differently
>>> performing disks attached might be best served by two worker
>>> threads, particularly if one such thread was in part CPU bound
>>> (inventing this use case is left as an exercise for the reader).
>>
>> In most cases you want to use aio=native anyway, and then the QEMU
>> thread pool is entirely bypassed.
> 
> 'most cases' - really? I thought anything using either qcow2 or
> ceph won't support that?

qcow2 works very well with aio=native.

ceph, libiscsi, gluster, etc. will not support aio=native indeed, but
then they won't use the thread pool either so I wasn't thinking about
them (only files and block devices).

Paolo

  reply	other threads:[~2013-11-11 18:45 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-04 10:28 [Qemu-devel] [PATCH v2 0/3] Make thread pool implementation modular Matthias Brugger
2013-11-04 10:28 ` [Qemu-devel] [PATCH v2 1/3] " Matthias Brugger
2013-11-11 12:28   ` Kevin Wolf
2013-11-04 10:28 ` [Qemu-devel] [PATCH v2 2/3] Block layer uses modular thread pool Matthias Brugger
2013-11-04 10:28 ` [Qemu-devel] [PATCH v2 3/3] Add workerthreads configuration option Matthias Brugger
2013-11-11 12:31   ` Kevin Wolf
2013-11-05 13:25 ` [Qemu-devel] [PATCH v2 0/3] Make thread pool implementation modular Stefan Hajnoczi
2013-11-11 10:00   ` Matthias Brugger
2013-11-11 12:43     ` Stefan Hajnoczi
2013-11-11 17:59       ` Alex Bligh
2013-11-11 18:01         ` Paolo Bonzini
2013-11-11 18:32           ` Alex Bligh
2013-11-11 18:44             ` Paolo Bonzini [this message]
2013-12-05  8:40       ` Matthias Brugger
2013-12-05  9:40         ` Paolo Bonzini
2013-12-05 10:22         ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52812591.3040903@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=afaerber@suse.de \
    --cc=alex@alex.org.uk \
    --cc=anthony@codemonkey.ws \
    --cc=armbru@redhat.com \
    --cc=asias@redhat.com \
    --cc=av1474@comtv.ru \
    --cc=ehabkost@redhat.com \
    --cc=jcody@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=matthias.bgg@gmail.com \
    --cc=mjt@tls.msk.ru \
    --cc=pingfank@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    --cc=stefanha@redhat.com \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.