All of lore.kernel.org
 help / color / mirror / Atom feed
From: dinh.linux@gmail.com (Dinh Nguyen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/4] Socfpga: clk: trivial fixes and cleanup
Date: Mon, 11 Nov 2013 21:40:34 -0600	[thread overview]
Message-ID: <5281A332.6060300@gmail.com> (raw)
In-Reply-To: <1384215177.17054.2.camel@linux-builds1>


On 11/11/13 6:12 PM, Dinh Nguyen wrote:
> Hi Steffen,
>
> On Thu, 2013-11-07 at 16:07 +0100, Steffen Trumtrar wrote:
>> Hi!
>>
>> This series includes two trivial fixes to the code (1,2),
>> then goes on to split the single clk.c file up into clock-type
>> specific files (3) and finally adds a divider to the peripheral
>> clock path.
>>
>> The patches are rebased to the for-next branch of
>>
>>         git://git.rocketboards.org/linux-socfpga-next.git
>>
>> Regards,
>> Steffen
>>
>> Steffen Trumtrar (4):
>>   ARM: socfpga: clk: remove unused field
>>   ARM: socfpga: clk: fix define typo
> The first two patches are fine.
>
>>   ARM: socfpga: clk: split clk code
>>   ARM: socfpga: clk: add clk_divider to periph
> These two patches are causing the ethernet driver to not be able to grab
> the correct clock during probe.
>
> Lets wait for 3.13-rc1 and I will push a new for-next that will be more
> up-to-date.

Also the values do not look correct with your patch:

per_nand_mmc_clk         1           1            52631578
          nand_clk              0           0            13157894
          nand_x_clk            0           0            52631578
          sdmmc_clk             1           1            52631578

Without your patch:

 per_nand_mmc_clk         1           1            50000000
          nand_clk              0           0            12500000
          nand_x_clk            0           0            50000000
          sdmmc_clk             1           1            50000000

Dinh
>
> Thanks,
>
> Dinh
>>  drivers/clk/socfpga/Makefile     |   3 +
>>  drivers/clk/socfpga/clk-gate.c   | 197 ++++++++++++++++++++++++
>>  drivers/clk/socfpga/clk-periph.c |  87 +++++++++++
>>  drivers/clk/socfpga/clk-pll.c    | 114 ++++++++++++++
>>  drivers/clk/socfpga/clk.c        | 313 +--------------------------------------
>>  drivers/clk/socfpga/clk.h        |  56 +++++++
>>  6 files changed, 458 insertions(+), 312 deletions(-)
>>  create mode 100644 drivers/clk/socfpga/clk-gate.c
>>  create mode 100644 drivers/clk/socfpga/clk-periph.c
>>  create mode 100644 drivers/clk/socfpga/clk-pll.c
>>  create mode 100644 drivers/clk/socfpga/clk.h
>>
>
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2013-11-12  3:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-07 15:07 [PATCH 0/4] Socfpga: clk: trivial fixes and cleanup Steffen Trumtrar
2013-11-07 15:07 ` [PATCH 1/4] ARM: socfpga: clk: remove unused field Steffen Trumtrar
2013-11-07 15:07 ` [PATCH 2/4] ARM: socfpga: clk: fix define typo Steffen Trumtrar
2013-11-07 15:07 ` [PATCH 3/4] ARM: socfpga: clk: split clk code Steffen Trumtrar
2013-11-07 15:07 ` [PATCH 4/4] ARM: socfpga: clk: add clk_divider to periph Steffen Trumtrar
2013-11-12  0:12 ` [PATCH 0/4] Socfpga: clk: trivial fixes and cleanup Dinh Nguyen
2013-11-12  3:40   ` Dinh Nguyen [this message]
2013-11-12  7:40     ` Steffen Trumtrar
     [not found]       ` <CADhT+wffgF1veA8ec4zF7J3_4tsKUZXcq5-X9cLCgN5D3A7Nrw@mail.gmail.com>
2013-11-19  8:14         ` Steffen Trumtrar
2013-11-19 16:21           ` Dinh Nguyen
2013-11-19 21:34           ` Dinh Nguyen
2013-11-19 22:07             ` Steffen Trumtrar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5281A332.6060300@gmail.com \
    --to=dinh.linux@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.