All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/7] eigen: add C++ toolchain dependency
Date: Tue, 12 Nov 2013 08:15:14 +0100	[thread overview]
Message-ID: <5281D582.7000809@mind.be> (raw)
In-Reply-To: <1384203613-17871-3-git-send-email-s.martin49@gmail.com>

On 11/11/13 22:00, Samuel Martin wrote:
> As said in its help text, eigen heavily uses C++ features.
> So, explicit this dependency in the Config.in.
>
> Signed-off-by: Samuel Martin <s.martin49@gmail.com>

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

> ---
>   package/eigen/Config.in | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/package/eigen/Config.in b/package/eigen/Config.in
> index c7fcde2..e94f9a3 100644
> --- a/package/eigen/Config.in
> +++ b/package/eigen/Config.in
> @@ -1,5 +1,6 @@
>   config BR2_PACKAGE_EIGEN
>   	bool "eigen"
> +	depends on BR2_INSTALL_LIBSTDCPP
>   	help
>   	  Eigen is a C++ template library for linear algebra: vectors,
>   	  matrices, and related algorithms. It is versatile, fast, elegant
> @@ -11,3 +12,6 @@ config BR2_PACKAGE_EIGEN
>   	  template library defined in the headers.
>
>   	  http://eigen.tuxfamily.org/
> +
> +comment "eigen needs a toolchain w/ C++"
> +	depends on !BR2_INSTALL_LIBSTDCPP
>


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

  reply	other threads:[~2013-11-12  7:15 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-11 21:00 [Buildroot] [PATCH 0/7] OpenCV bump Samuel Martin
2013-11-11 21:00 ` [Buildroot] [PATCH 1/7] cmake: bump to version 2.8.12.1 Samuel Martin
2013-11-11 21:00 ` [Buildroot] [PATCH 2/7] eigen: add C++ toolchain dependency Samuel Martin
2013-11-12  7:15   ` Arnout Vandecappelle [this message]
2013-11-11 21:00 ` [Buildroot] [PATCH 3/7] eigen: fix install rules Samuel Martin
2013-11-11 22:33   ` Thomas Petazzoni
2013-11-12  7:24     ` Arnout Vandecappelle
2013-11-12  8:28       ` Samuel Martin
2013-11-15 20:28         ` Samuel Martin
2013-11-11 21:00 ` [Buildroot] [PATCH 4/7] opencv: add eigen dependency Samuel Martin
2013-11-11 22:36   ` Thomas Petazzoni
2013-11-15 20:22     ` Samuel Martin
2013-11-11 21:00 ` [Buildroot] [PATCH 5/7] opencv: bump to version 2.4.7 Samuel Martin
2013-11-11 21:00 ` [Buildroot] [PATCH 6/7] opencv: rework V4L/libv4l support Samuel Martin
2013-11-11 21:00 ` [Buildroot] [PATCH 7/7] opencv: add Qt5 support Samuel Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5281D582.7000809@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.