All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] trats: enable dfu and thor protocol for Tizen download
@ 2013-11-12  8:58 Piotr Wilczek
  2013-11-12  9:23 ` Jaehoon Chung
  2013-11-12 14:22 ` [U-Boot] [PATCH V2] trats2: " Piotr Wilczek
  0 siblings, 2 replies; 5+ messages in thread
From: Piotr Wilczek @ 2013-11-12  8:58 UTC (permalink / raw)
  To: u-boot

Trats2 config is updated to support DFU mode.
Malloc pool must be increased for DFU buffer allocation.

Signed-off-by: Piotr Wilczek <p.wilczek@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
CC: Minkyu Kang <mk7.kang@samsung.com>
---
This patch is based on
http://patchwork.ozlabs.org/patch/289378/

 include/configs/trats2.h |   22 ++++++++++++++++++----
 1 file changed, 18 insertions(+), 4 deletions(-)

diff --git a/include/configs/trats2.h b/include/configs/trats2.h
index 66b1c95..52bb5e5 100644
--- a/include/configs/trats2.h
+++ b/include/configs/trats2.h
@@ -65,10 +65,9 @@
 
 #define CONFIG_DISPLAY_CPUINFO
 
-/*
- * Size of malloc() pool
- */
-#define CONFIG_SYS_MALLOC_LEN		(CONFIG_ENV_SIZE + (2 << 20))
+#include <asm/sizes.h>
+/* Size of malloc() pool */
+#define CONFIG_SYS_MALLOC_LEN		(CONFIG_ENV_SIZE + (80 * SZ_1M))
 
 /* select serial console configuration */
 #define CONFIG_SERIAL2
@@ -100,6 +99,7 @@
 #define CONFIG_CMD_CACHE
 #define CONFIG_CMD_I2C
 #define CONFIG_CMD_MMC
+#define CONFIG_CMD_DFU
 #define CONFIG_CMD_GPT
 #define CONFIG_CMD_PMIC
 
@@ -115,12 +115,19 @@
 
 /* USB Composite download gadget - g_dnl */
 #define CONFIG_USBDOWNLOAD_GADGET
+#define CONFIG_SYS_DFU_DATA_BUF_SIZE SZ_32M
 #define CONFIG_DFU_FUNCTION
 #define CONFIG_DFU_MMC
 
+/* TIZEN THOR downloader support */
+#define CONFIG_CMD_THOR_DOWNLOAD
+#define CONFIG_THOR_FUNCTION
+
 /* USB Samsung's IDs */
 #define CONFIG_G_DNL_VENDOR_NUM 0x04E8
 #define CONFIG_G_DNL_PRODUCT_NUM 0x6601
+#define CONFIG_G_DNL_THOR_VENDOR_NUM CONFIG_G_DNL_VENDOR_NUM
+#define CONFIG_G_DNL_THOR_PRODUCT_NUM 0x685D
 #define CONFIG_G_DNL_MANUFACTURER "Samsung"
 
 /* To use the TFTPBOOT over USB, Please enable the CONFIG_CMD_NET */
@@ -165,6 +172,12 @@
 	"name="PARTS_CSC",size=150MiB,uuid=${uuid_gpt_"PARTS_CSC"};" \
 	"name="PARTS_UMS",size=-,uuid=${uuid_gpt_"PARTS_UMS"}\0" \
 
+#define CONFIG_DFU_ALT \
+	"u-boot mmc 80 400;" \
+	"uImage ext4 0 2;" \
+	"exynos4412-trats2.dtb ext4 0 2;" \
+	""PARTS_ROOT" part 0 5\0"
+
 #define CONFIG_EXTRA_ENV_SETTINGS \
 	"bootk=" \
 		"run loaddtb; run loaduimage; bootm 0x40007FC0 - ${fdtaddr}\0" \
@@ -197,6 +210,7 @@
 	"mmcrootpart=5\0" \
 	"opts=always_resume=1\0" \
 	"partitions=" PARTS_DEFAULT \
+	"dfu_alt_info=" CONFIG_DFU_ALT \
 	"uartpath=ap\0" \
 	"usbpath=ap\0" \
 	"consoleon=set console console=ttySAC2,115200n8; save; reset\0" \
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [U-Boot] [PATCH] trats: enable dfu and thor protocol for Tizen download
  2013-11-12  8:58 [U-Boot] [PATCH] trats: enable dfu and thor protocol for Tizen download Piotr Wilczek
@ 2013-11-12  9:23 ` Jaehoon Chung
  2013-11-12  9:34   ` Piotr Wilczek
  2013-11-12 14:22 ` [U-Boot] [PATCH V2] trats2: " Piotr Wilczek
  1 sibling, 1 reply; 5+ messages in thread
From: Jaehoon Chung @ 2013-11-12  9:23 UTC (permalink / raw)
  To: u-boot

Hi Piotr,

I think good that used the "trats2:xxx" instead of "trats: xxx" at subject.

On 11/12/2013 05:58 PM, Piotr Wilczek wrote:
> Trats2 config is updated to support DFU mode.
> Malloc pool must be increased for DFU buffer allocation.
> 
> Signed-off-by: Piotr Wilczek <p.wilczek@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> CC: Minkyu Kang <mk7.kang@samsung.com>
> ---
> This patch is based on
> http://patchwork.ozlabs.org/patch/289378/
> 
>  include/configs/trats2.h |   22 ++++++++++++++++++----
>  1 file changed, 18 insertions(+), 4 deletions(-)
> 
> diff --git a/include/configs/trats2.h b/include/configs/trats2.h
> index 66b1c95..52bb5e5 100644
> --- a/include/configs/trats2.h
> +++ b/include/configs/trats2.h
> @@ -65,10 +65,9 @@
>  
>  #define CONFIG_DISPLAY_CPUINFO
>  
> -/*
> - * Size of malloc() pool
> - */
> -#define CONFIG_SYS_MALLOC_LEN		(CONFIG_ENV_SIZE + (2 << 20))
> +#include <asm/sizes.h>
> +/* Size of malloc() pool */
> +#define CONFIG_SYS_MALLOC_LEN		(CONFIG_ENV_SIZE + (80 * SZ_1M))
>  
>  /* select serial console configuration */
>  #define CONFIG_SERIAL2
> @@ -100,6 +99,7 @@
>  #define CONFIG_CMD_CACHE
>  #define CONFIG_CMD_I2C
>  #define CONFIG_CMD_MMC
> +#define CONFIG_CMD_DFU
>  #define CONFIG_CMD_GPT
>  #define CONFIG_CMD_PMIC
>  
> @@ -115,12 +115,19 @@
>  
>  /* USB Composite download gadget - g_dnl */
>  #define CONFIG_USBDOWNLOAD_GADGET
> +#define CONFIG_SYS_DFU_DATA_BUF_SIZE SZ_32M
>  #define CONFIG_DFU_FUNCTION
>  #define CONFIG_DFU_MMC
>  
> +/* TIZEN THOR downloader support */
> +#define CONFIG_CMD_THOR_DOWNLOAD
> +#define CONFIG_THOR_FUNCTION
> +
>  /* USB Samsung's IDs */
>  #define CONFIG_G_DNL_VENDOR_NUM 0x04E8
>  #define CONFIG_G_DNL_PRODUCT_NUM 0x6601
> +#define CONFIG_G_DNL_THOR_VENDOR_NUM CONFIG_G_DNL_VENDOR_NUM
> +#define CONFIG_G_DNL_THOR_PRODUCT_NUM 0x685D
>  #define CONFIG_G_DNL_MANUFACTURER "Samsung"
>  
>  /* To use the TFTPBOOT over USB, Please enable the CONFIG_CMD_NET */
> @@ -165,6 +172,12 @@
>  	"name="PARTS_CSC",size=150MiB,uuid=${uuid_gpt_"PARTS_CSC"};" \
>  	"name="PARTS_UMS",size=-,uuid=${uuid_gpt_"PARTS_UMS"}\0" \
>  
> +#define CONFIG_DFU_ALT \
> +	"u-boot mmc 80 400;" \
I recommend the "u-boot mmc 80 800"

Best Regards,
Jaehoon Chung
> +	"uImage ext4 0 2;" \
> +	"exynos4412-trats2.dtb ext4 0 2;" \
> +	""PARTS_ROOT" part 0 5\0"
> +
>  #define CONFIG_EXTRA_ENV_SETTINGS \
>  	"bootk=" \
>  		"run loaddtb; run loaduimage; bootm 0x40007FC0 - ${fdtaddr}\0" \
> @@ -197,6 +210,7 @@
>  	"mmcrootpart=5\0" \
>  	"opts=always_resume=1\0" \
>  	"partitions=" PARTS_DEFAULT \
> +	"dfu_alt_info=" CONFIG_DFU_ALT \
>  	"uartpath=ap\0" \
>  	"usbpath=ap\0" \
>  	"consoleon=set console console=ttySAC2,115200n8; save; reset\0" \
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [U-Boot] [PATCH] trats: enable dfu and thor protocol for Tizen download
  2013-11-12  9:23 ` Jaehoon Chung
@ 2013-11-12  9:34   ` Piotr Wilczek
  0 siblings, 0 replies; 5+ messages in thread
From: Piotr Wilczek @ 2013-11-12  9:34 UTC (permalink / raw)
  To: u-boot

Hi Jaehoon,

> -----Original Message-----
> From: Jaehoon Chung [mailto:jh80.chung at samsung.com]
> Sent: Tuesday, November 12, 2013 10:23 AM
> To: Piotr Wilczek; u-boot at lists.denx.de
> Cc: Kyungmin Park
> Subject: Re: [U-Boot] [PATCH] trats: enable dfu and thor protocol for
> Tizen download
> 
> Hi Piotr,
> 
> I think good that used the "trats2:xxx" instead of "trats: xxx" at
> subject.
Yes, I overlook that, will fix.

> 
> On 11/12/2013 05:58 PM, Piotr Wilczek wrote:
> > Trats2 config is updated to support DFU mode.
> > Malloc pool must be increased for DFU buffer allocation.
> >
> > Signed-off-by: Piotr Wilczek <p.wilczek@samsung.com>
> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> > CC: Minkyu Kang <mk7.kang@samsung.com>
> > ---
> > This patch is based on
> > http://patchwork.ozlabs.org/patch/289378/
> >
> >  include/configs/trats2.h |   22 ++++++++++++++++++----
> >  1 file changed, 18 insertions(+), 4 deletions(-)
> >
> > diff --git a/include/configs/trats2.h b/include/configs/trats2.h
> index
> > 66b1c95..52bb5e5 100644
> > --- a/include/configs/trats2.h
> > +++ b/include/configs/trats2.h
> > @@ -65,10 +65,9 @@
> >
> >  #define CONFIG_DISPLAY_CPUINFO
> >
> > -/*
> > - * Size of malloc() pool
> > - */
> > -#define CONFIG_SYS_MALLOC_LEN		(CONFIG_ENV_SIZE + (2 <<
20))
> > +#include <asm/sizes.h>
> > +/* Size of malloc() pool */
> > +#define CONFIG_SYS_MALLOC_LEN		(CONFIG_ENV_SIZE + (80 *
> SZ_1M))
> >
> >  /* select serial console configuration */  #define CONFIG_SERIAL2 @@
> > -100,6 +99,7 @@  #define CONFIG_CMD_CACHE  #define CONFIG_CMD_I2C
> > #define CONFIG_CMD_MMC
> > +#define CONFIG_CMD_DFU
> >  #define CONFIG_CMD_GPT
> >  #define CONFIG_CMD_PMIC
> >
> > @@ -115,12 +115,19 @@
> >
> >  /* USB Composite download gadget - g_dnl */  #define
> > CONFIG_USBDOWNLOAD_GADGET
> > +#define CONFIG_SYS_DFU_DATA_BUF_SIZE SZ_32M
> >  #define CONFIG_DFU_FUNCTION
> >  #define CONFIG_DFU_MMC
> >
> > +/* TIZEN THOR downloader support */
> > +#define CONFIG_CMD_THOR_DOWNLOAD
> > +#define CONFIG_THOR_FUNCTION
> > +
> >  /* USB Samsung's IDs */
> >  #define CONFIG_G_DNL_VENDOR_NUM 0x04E8  #define
> > CONFIG_G_DNL_PRODUCT_NUM 0x6601
> > +#define CONFIG_G_DNL_THOR_VENDOR_NUM CONFIG_G_DNL_VENDOR_NUM #define
> > +CONFIG_G_DNL_THOR_PRODUCT_NUM 0x685D
> >  #define CONFIG_G_DNL_MANUFACTURER "Samsung"
> >
> >  /* To use the TFTPBOOT over USB, Please enable the CONFIG_CMD_NET */
> > @@ -165,6 +172,12 @@
> >  	"name="PARTS_CSC",size=150MiB,uuid=${uuid_gpt_"PARTS_CSC"};" \
> >  	"name="PARTS_UMS",size=-,uuid=${uuid_gpt_"PARTS_UMS"}\0" \
> >
> > +#define CONFIG_DFU_ALT \
> > +	"u-boot mmc 80 400;" \
> I recommend the "u-boot mmc 80 800"
Ok

> 
> Best Regards,
> Jaehoon Chung
> > +	"uImage ext4 0 2;" \
> > +	"exynos4412-trats2.dtb ext4 0 2;" \
> > +	""PARTS_ROOT" part 0 5\0"
> > +
> >  #define CONFIG_EXTRA_ENV_SETTINGS \
> >  	"bootk=" \
> >  		"run loaddtb; run loaduimage; bootm 0x40007FC0 -
> ${fdtaddr}\0" \ @@
> > -197,6 +210,7 @@
> >  	"mmcrootpart=5\0" \
> >  	"opts=always_resume=1\0" \
> >  	"partitions=" PARTS_DEFAULT \
> > +	"dfu_alt_info=" CONFIG_DFU_ALT \
> >  	"uartpath=ap\0" \
> >  	"usbpath=ap\0" \
> >  	"consoleon=set console console=ttySAC2,115200n8; save; reset\0" \
> >

Best regards,
Piotr Wilczek

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [U-Boot] [PATCH V2] trats2: enable dfu and thor protocol for Tizen download
  2013-11-12  8:58 [U-Boot] [PATCH] trats: enable dfu and thor protocol for Tizen download Piotr Wilczek
  2013-11-12  9:23 ` Jaehoon Chung
@ 2013-11-12 14:22 ` Piotr Wilczek
  2013-12-02  7:53   ` Minkyu Kang
  1 sibling, 1 reply; 5+ messages in thread
From: Piotr Wilczek @ 2013-11-12 14:22 UTC (permalink / raw)
  To: u-boot

Trats2 config is updated to support DFU mode.
Malloc pool must be increased for DFU buffer allocation.

Signed-off-by: Piotr Wilczek <p.wilczek@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
CC: Minkyu Kang <mk7.kang@samsung.com>
---
Changes for v2:
 - modified subject to reflect that the patch is for Trats2;
 - changed u-boot write size to 0x800 in dfu alts;
 
This patch is based on
http://patchwork.ozlabs.org/patch/289378/

 include/configs/trats2.h |   22 ++++++++++++++++++----
 1 file changed, 18 insertions(+), 4 deletions(-)

diff --git a/include/configs/trats2.h b/include/configs/trats2.h
index 66b1c95..bf49dd5 100644
--- a/include/configs/trats2.h
+++ b/include/configs/trats2.h
@@ -65,10 +65,9 @@
 
 #define CONFIG_DISPLAY_CPUINFO
 
-/*
- * Size of malloc() pool
- */
-#define CONFIG_SYS_MALLOC_LEN		(CONFIG_ENV_SIZE + (2 << 20))
+#include <asm/sizes.h>
+/* Size of malloc() pool */
+#define CONFIG_SYS_MALLOC_LEN		(CONFIG_ENV_SIZE + (80 * SZ_1M))
 
 /* select serial console configuration */
 #define CONFIG_SERIAL2
@@ -100,6 +99,7 @@
 #define CONFIG_CMD_CACHE
 #define CONFIG_CMD_I2C
 #define CONFIG_CMD_MMC
+#define CONFIG_CMD_DFU
 #define CONFIG_CMD_GPT
 #define CONFIG_CMD_PMIC
 
@@ -115,12 +115,19 @@
 
 /* USB Composite download gadget - g_dnl */
 #define CONFIG_USBDOWNLOAD_GADGET
+#define CONFIG_SYS_DFU_DATA_BUF_SIZE SZ_32M
 #define CONFIG_DFU_FUNCTION
 #define CONFIG_DFU_MMC
 
+/* TIZEN THOR downloader support */
+#define CONFIG_CMD_THOR_DOWNLOAD
+#define CONFIG_THOR_FUNCTION
+
 /* USB Samsung's IDs */
 #define CONFIG_G_DNL_VENDOR_NUM 0x04E8
 #define CONFIG_G_DNL_PRODUCT_NUM 0x6601
+#define CONFIG_G_DNL_THOR_VENDOR_NUM CONFIG_G_DNL_VENDOR_NUM
+#define CONFIG_G_DNL_THOR_PRODUCT_NUM 0x685D
 #define CONFIG_G_DNL_MANUFACTURER "Samsung"
 
 /* To use the TFTPBOOT over USB, Please enable the CONFIG_CMD_NET */
@@ -165,6 +172,12 @@
 	"name="PARTS_CSC",size=150MiB,uuid=${uuid_gpt_"PARTS_CSC"};" \
 	"name="PARTS_UMS",size=-,uuid=${uuid_gpt_"PARTS_UMS"}\0" \
 
+#define CONFIG_DFU_ALT \
+	"u-boot mmc 80 800;" \
+	"uImage ext4 0 2;" \
+	"exynos4412-trats2.dtb ext4 0 2;" \
+	""PARTS_ROOT" part 0 5\0"
+
 #define CONFIG_EXTRA_ENV_SETTINGS \
 	"bootk=" \
 		"run loaddtb; run loaduimage; bootm 0x40007FC0 - ${fdtaddr}\0" \
@@ -197,6 +210,7 @@
 	"mmcrootpart=5\0" \
 	"opts=always_resume=1\0" \
 	"partitions=" PARTS_DEFAULT \
+	"dfu_alt_info=" CONFIG_DFU_ALT \
 	"uartpath=ap\0" \
 	"usbpath=ap\0" \
 	"consoleon=set console console=ttySAC2,115200n8; save; reset\0" \
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [U-Boot] [PATCH V2] trats2: enable dfu and thor protocol for Tizen download
  2013-11-12 14:22 ` [U-Boot] [PATCH V2] trats2: " Piotr Wilczek
@ 2013-12-02  7:53   ` Minkyu Kang
  0 siblings, 0 replies; 5+ messages in thread
From: Minkyu Kang @ 2013-12-02  7:53 UTC (permalink / raw)
  To: u-boot

Dear Piotr Wilczek,

On 12/11/13 23:22, Piotr Wilczek wrote:
> Trats2 config is updated to support DFU mode.
> Malloc pool must be increased for DFU buffer allocation.
> 
> Signed-off-by: Piotr Wilczek <p.wilczek@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> CC: Minkyu Kang <mk7.kang@samsung.com>
> ---
> Changes for v2:
>  - modified subject to reflect that the patch is for Trats2;
>  - changed u-boot write size to 0x800 in dfu alts;
>  
> This patch is based on
> http://patchwork.ozlabs.org/patch/289378/
> 
>  include/configs/trats2.h |   22 ++++++++++++++++++----
>  1 file changed, 18 insertions(+), 4 deletions(-)
> 

applied to u-boot-samsung.

Thanks,
Minkyu Kang.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2013-12-02  7:53 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-12  8:58 [U-Boot] [PATCH] trats: enable dfu and thor protocol for Tizen download Piotr Wilczek
2013-11-12  9:23 ` Jaehoon Chung
2013-11-12  9:34   ` Piotr Wilczek
2013-11-12 14:22 ` [U-Boot] [PATCH V2] trats2: " Piotr Wilczek
2013-12-02  7:53   ` Minkyu Kang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.