From: Michal Marek <mmarek@suse.cz>
To: Arnaud Patard <arnaud.patard@rtp-net.org>
Cc: Ben Hutchings <ben@decadent.org.uk>,
linux-kbuild@vger.kernel.org, maximilian attems <max@stro.at>
Subject: Re: [patch 1/1] deb-pkg: Add device tree blobs to the package
Date: Tue, 12 Nov 2013 13:52:22 +0100 [thread overview]
Message-ID: <52822486.9090209@suse.cz> (raw)
In-Reply-To: <1383921387.8136.30.camel@deadeye.wl.decadent.org.uk>
On 8.11.2013 15:36, Ben Hutchings wrote:
> On Thu, 2013-11-07 at 16:17 +0100, Arnaud Patard wrote:
>> When building a package with make deb-pkg (say, for arm), the dtb files are
>> not added to the package. Given that things are still evolving on arm, it
>> make sense to have them along with the kernel and modules.
>>
>> Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>
>> ---
>>
>> Index: linux-next/scripts/package/builddeb
>> ===================================================================
>> --- linux-next.orig/scripts/package/builddeb 2013-11-06 12:51:49.548299578 +0100
>> +++ linux-next/scripts/package/builddeb 2013-11-06 12:52:24.152298055 +0100
>> @@ -140,6 +140,10 @@ if [ -e $KBUILD_IMAGE ]; then
>> else
>> cp arch/$ARCH/boot/$KBUILD_IMAGE "$tmpdir/$installed_image_path"
>> fi
>> +if grep -q "^CONFIG_OF=y" .config ; then
>> + mkdir -p "$tmpdir/usr/lib/$packagename"
>> + find arch/$ARCH -name *.dtb -exec cp {} "$tmpdir/usr/lib/$packagename" \;
>> +fi
>
> I would quote the '*.dtb'. Otherwise I think this is reasonable.
Good catch. Arnaud, can you send a v2 with this fix?
Thanks,
Michal
prev parent reply other threads:[~2013-11-12 12:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-07 15:17 [patch 1/1] deb-pkg: Add device tree blobs to the package Arnaud Patard
2013-11-08 14:36 ` Ben Hutchings
2013-11-12 12:52 ` Michal Marek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52822486.9090209@suse.cz \
--to=mmarek@suse.cz \
--cc=arnaud.patard@rtp-net.org \
--cc=ben@decadent.org.uk \
--cc=linux-kbuild@vger.kernel.org \
--cc=max@stro.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.