From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: "Khoronzhuk, Ivan" <ivan.khoronzhuk@ti.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Strashko, Grygorii" <grygorii.strashko@ti.com>,
Russell King <linux@arm.linux.org.uk>,
Pawel Moll <pawel.moll@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@kernel.crashing.org>,
Rob Herring <rob.herring@calxeda.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
Rob Landley <rob@landley.net>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 03/12] mtd: nand: davinci: simplify error handling
Date: Tue, 12 Nov 2013 10:52:57 -0500 [thread overview]
Message-ID: <52824ED9.5040104@ti.com> (raw)
In-Reply-To: <4F5844B3A985794BA902E12C070812375F8CFB@DNCE04.ent.ti.com>
On Monday 11 November 2013 11:54 AM, Khoronzhuk, Ivan wrote:
> There is not needed to use a lot of names for err handling.
> It complicates code support and reading.
>
This is not always true but looking at the patch, the labels
are just useless since no special handling per label.
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
> ---
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
WARNING: multiple messages have this Message-ID (diff)
From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 03/12] mtd: nand: davinci: simplify error handling
Date: Tue, 12 Nov 2013 10:52:57 -0500 [thread overview]
Message-ID: <52824ED9.5040104@ti.com> (raw)
In-Reply-To: <4F5844B3A985794BA902E12C070812375F8CFB@DNCE04.ent.ti.com>
On Monday 11 November 2013 11:54 AM, Khoronzhuk, Ivan wrote:
> There is not needed to use a lot of names for err handling.
> It complicates code support and reading.
>
This is not always true but looking at the patch, the labels
are just useless since no special handling per label.
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
> ---
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
WARNING: multiple messages have this Message-ID (diff)
From: Santosh Shilimkar <santosh.shilimkar-l0cyMroinI0@public.gmane.org>
To: "Khoronzhuk, Ivan" <ivan.khoronzhuk-l0cyMroinI0@public.gmane.org>
Cc: Rob Landley <rob-VoJi6FS/r0vR7s880joybQ@public.gmane.org>,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
Kumar Gala
<galak-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"Strashko,
Grygorii" <grygorii.strashko-l0cyMroinI0@public.gmane.org>
Subject: Re: [PATCH 03/12] mtd: nand: davinci: simplify error handling
Date: Tue, 12 Nov 2013 10:52:57 -0500 [thread overview]
Message-ID: <52824ED9.5040104@ti.com> (raw)
In-Reply-To: <4F5844B3A985794BA902E12C070812375F8CFB-bXo5r3zvlxeIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
On Monday 11 November 2013 11:54 AM, Khoronzhuk, Ivan wrote:
> There is not needed to use a lot of names for err handling.
> It complicates code support and reading.
>
This is not always true but looking at the patch, the labels
are just useless since no special handling per label.
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk-l0cyMroinI0@public.gmane.org>
> ---
Acked-by: Santosh Shilimkar <santosh.shilimkar-l0cyMroinI0@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: "Khoronzhuk, Ivan" <ivan.khoronzhuk@ti.com>
Cc: Rob Landley <rob@landley.net>,
Russell King <linux@arm.linux.org.uk>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <rob.herring@calxeda.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Kumar Gala <galak@kernel.crashing.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"Strashko, Grygorii" <grygorii.strashko@ti.com>
Subject: Re: [PATCH 03/12] mtd: nand: davinci: simplify error handling
Date: Tue, 12 Nov 2013 10:52:57 -0500 [thread overview]
Message-ID: <52824ED9.5040104@ti.com> (raw)
In-Reply-To: <4F5844B3A985794BA902E12C070812375F8CFB@DNCE04.ent.ti.com>
On Monday 11 November 2013 11:54 AM, Khoronzhuk, Ivan wrote:
> There is not needed to use a lot of names for err handling.
> It complicates code support and reading.
>
This is not always true but looking at the patch, the labels
are just useless since no special handling per label.
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
> ---
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
next prev parent reply other threads:[~2013-11-12 15:52 UTC|newest]
Thread overview: 200+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1384187188-5776-1-git-send-email-ivan.khoronzhuk@ti.com>
2013-11-11 16:47 ` [PATCH 00/12] Introduce davinci AEMIF driver Khoronzhuk, Ivan
2013-11-11 16:47 ` Khoronzhuk, Ivan
2013-11-11 16:47 ` Khoronzhuk, Ivan
[not found] ` <1384187188-5776-2-git-send-email-ivan.khoronzhuk@ti.com>
2013-11-11 16:52 ` [PATCH 01/12] mtd: nand: davinci: fix driver registration Khoronzhuk, Ivan
2013-11-11 16:52 ` Khoronzhuk, Ivan
2013-11-11 16:52 ` Khoronzhuk, Ivan
2013-11-12 15:45 ` Santosh Shilimkar
2013-11-12 15:45 ` Santosh Shilimkar
2013-11-12 15:45 ` Santosh Shilimkar
[not found] ` <1384187188-5776-3-git-send-email-ivan.khoronzhuk@ti.com>
2013-11-11 16:53 ` [PATCH 02/12] mtd: nand: davinci: check required ti,davinci-chipselect property Khoronzhuk, Ivan
2013-11-11 16:53 ` Khoronzhuk, Ivan
2013-11-11 16:53 ` Khoronzhuk, Ivan
2013-11-12 15:50 ` [PATCH 02/12] mtd: nand: davinci: check required ti, davinci-chipselect property Santosh Shilimkar
2013-11-12 15:50 ` [PATCH 02/12] mtd: nand: davinci: check required ti,davinci-chipselect property Santosh Shilimkar
2013-11-12 15:50 ` [PATCH 02/12] mtd: nand: davinci: check required ti, davinci-chipselect property Santosh Shilimkar
2013-11-18 18:25 ` ivan.khoronzhuk
2013-11-18 18:25 ` [PATCH 02/12] mtd: nand: davinci: check required ti,davinci-chipselect property ivan.khoronzhuk
2013-11-18 18:25 ` [PATCH 02/12] mtd: nand: davinci: check required ti, davinci-chipselect property ivan.khoronzhuk
2013-11-18 18:25 ` ivan.khoronzhuk
[not found] ` <1384187188-5776-4-git-send-email-ivan.khoronzhuk@ti.com>
2013-11-11 16:54 ` [PATCH 03/12] mtd: nand: davinci: simplify error handling Khoronzhuk, Ivan
2013-11-11 16:54 ` Khoronzhuk, Ivan
2013-11-11 16:54 ` Khoronzhuk, Ivan
2013-11-12 15:52 ` Santosh Shilimkar [this message]
2013-11-12 15:52 ` Santosh Shilimkar
2013-11-12 15:52 ` Santosh Shilimkar
2013-11-12 15:52 ` Santosh Shilimkar
[not found] ` <1384187188-5776-5-git-send-email-ivan.khoronzhuk@ti.com>
2013-11-11 16:55 ` [PATCH 04/12] mtd: nand: davinci: move bindings under mtd Khoronzhuk, Ivan
2013-11-11 16:55 ` Khoronzhuk, Ivan
2013-11-11 16:55 ` Khoronzhuk, Ivan
2013-11-11 16:55 ` Khoronzhuk, Ivan
2013-11-12 15:53 ` Santosh Shilimkar
2013-11-12 15:53 ` Santosh Shilimkar
2013-11-12 15:53 ` Santosh Shilimkar
2013-11-12 15:53 ` Santosh Shilimkar
[not found] ` <1384187188-5776-6-git-send-email-ivan.khoronzhuk@ti.com>
2013-11-11 16:58 ` [PATCH 05/12] mtd: nand: davinci: extend description of bindings Khoronzhuk, Ivan
2013-11-11 16:58 ` Khoronzhuk, Ivan
2013-11-11 16:58 ` Khoronzhuk, Ivan
2013-11-11 16:58 ` Khoronzhuk, Ivan
2013-11-12 15:55 ` Santosh Shilimkar
2013-11-12 15:55 ` Santosh Shilimkar
2013-11-12 15:55 ` Santosh Shilimkar
2013-11-12 15:55 ` Santosh Shilimkar
[not found] ` <1384187188-5776-7-git-send-email-ivan.khoronzhuk@ti.com>
2013-11-11 17:01 ` [PATCH 06/12] mtd: nand: davinci: adjust DT properties to MTD generic Khoronzhuk, Ivan
2013-11-11 17:01 ` Khoronzhuk, Ivan
2013-11-11 17:01 ` Khoronzhuk, Ivan
2013-11-26 7:03 ` Sekhar Nori
2013-11-26 7:03 ` Sekhar Nori
2013-11-26 7:03 ` Sekhar Nori
2013-11-26 7:03 ` Sekhar Nori
2013-11-26 10:30 ` Grygorii Strashko
2013-11-26 10:30 ` Grygorii Strashko
2013-11-26 10:30 ` Grygorii Strashko
2013-11-26 10:49 ` ivan.khoronzhuk
2013-11-26 10:49 ` ivan.khoronzhuk
2013-11-26 10:49 ` ivan.khoronzhuk
2013-11-26 10:49 ` ivan.khoronzhuk
[not found] ` <1384187188-5776-8-git-send-email-ivan.khoronzhuk@ti.com>
2013-11-11 17:06 ` [PATCH 07/12] memory: davinci-aemif: introduce AEMIF driver Khoronzhuk, Ivan
2013-11-11 17:06 ` Khoronzhuk, Ivan
2013-11-11 17:06 ` Khoronzhuk, Ivan
2013-11-11 17:06 ` Khoronzhuk, Ivan
2013-11-12 16:08 ` Santosh Shilimkar
2013-11-12 16:08 ` Santosh Shilimkar
2013-11-12 16:08 ` Santosh Shilimkar
2013-11-12 16:08 ` Santosh Shilimkar
2013-11-18 19:15 ` ivan.khoronzhuk
2013-11-18 19:15 ` ivan.khoronzhuk
2013-11-18 19:15 ` ivan.khoronzhuk
2013-11-18 19:15 ` ivan.khoronzhuk
2013-11-26 7:20 ` Sekhar Nori
2013-11-26 7:20 ` Sekhar Nori
2013-11-26 7:20 ` Sekhar Nori
2013-11-26 7:20 ` Sekhar Nori
2013-11-26 15:05 ` Santosh Shilimkar
2013-11-26 15:05 ` Santosh Shilimkar
2013-11-26 15:05 ` Santosh Shilimkar
2013-11-26 15:05 ` Santosh Shilimkar
2013-11-26 17:21 ` Sekhar Nori
2013-11-26 17:21 ` Sekhar Nori
2013-11-26 17:21 ` Sekhar Nori
2013-11-26 17:21 ` Sekhar Nori
2013-11-26 18:26 ` Santosh Shilimkar
2013-11-26 18:26 ` Santosh Shilimkar
2013-11-26 18:26 ` Santosh Shilimkar
2013-11-26 18:26 ` Santosh Shilimkar
2013-11-26 18:29 ` ivan.khoronzhuk
2013-11-26 18:29 ` ivan.khoronzhuk
2013-11-26 18:29 ` ivan.khoronzhuk
2013-11-27 0:37 ` Brian Norris
2013-11-27 0:37 ` Brian Norris
2013-11-27 0:37 ` Brian Norris
2013-11-27 0:37 ` Brian Norris
2013-11-27 10:22 ` ivan.khoronzhuk
2013-11-27 10:22 ` ivan.khoronzhuk
2013-11-27 10:22 ` ivan.khoronzhuk
2013-11-26 17:44 ` ivan.khoronzhuk
2013-11-26 17:44 ` ivan.khoronzhuk
2013-11-26 17:44 ` ivan.khoronzhuk
2013-11-26 18:30 ` Santosh Shilimkar
2013-11-26 18:30 ` Santosh Shilimkar
2013-11-26 18:30 ` Santosh Shilimkar
2013-11-26 18:30 ` Santosh Shilimkar
2013-11-26 18:30 ` ivan.khoronzhuk
2013-11-26 18:30 ` ivan.khoronzhuk
2013-11-26 18:30 ` ivan.khoronzhuk
2013-11-26 18:30 ` ivan.khoronzhuk
2013-11-27 4:05 ` Sekhar Nori
2013-11-27 4:05 ` Sekhar Nori
2013-11-27 4:05 ` Sekhar Nori
2013-11-27 4:05 ` Sekhar Nori
[not found] ` <1384187188-5776-9-git-send-email-ivan.khoronzhuk@ti.com>
2013-11-11 17:09 ` [PATCH 08/12] memory: davinci-aemif: add bindings for " Khoronzhuk, Ivan
2013-11-11 17:09 ` Khoronzhuk, Ivan
2013-11-11 17:09 ` Khoronzhuk, Ivan
2013-11-11 17:09 ` Khoronzhuk, Ivan
[not found] ` <1384187188-5776-10-git-send-email-ivan.khoronzhuk@ti.com>
2013-11-11 17:09 ` [PATCH 09/12] mtd: nand: davinci: reuse driver for Keystone arch Khoronzhuk, Ivan
2013-11-11 17:09 ` Khoronzhuk, Ivan
2013-11-11 17:09 ` Khoronzhuk, Ivan
2013-11-11 17:09 ` Khoronzhuk, Ivan
2013-11-12 16:09 ` Santosh Shilimkar
2013-11-12 16:09 ` Santosh Shilimkar
2013-11-12 16:09 ` Santosh Shilimkar
[not found] ` <1384187188-5776-11-git-send-email-ivan.khoronzhuk@ti.com>
2013-11-11 17:10 ` [PATCH 10/12] mtd: nand: davinci: don't set timings if AEMIF is used Khoronzhuk, Ivan
2013-11-11 17:10 ` Khoronzhuk, Ivan
2013-11-11 17:10 ` Khoronzhuk, Ivan
2013-11-11 17:10 ` Khoronzhuk, Ivan
2013-11-12 16:13 ` Santosh Shilimkar
2013-11-12 16:13 ` Santosh Shilimkar
2013-11-12 16:13 ` Santosh Shilimkar
2013-11-12 16:13 ` Santosh Shilimkar
2013-11-18 11:35 ` Grygorii Strashko
2013-11-18 11:35 ` Grygorii Strashko
2013-11-18 11:35 ` Grygorii Strashko
2013-11-18 11:35 ` Grygorii Strashko
2013-11-18 14:08 ` Santosh Shilimkar
2013-11-18 14:08 ` Santosh Shilimkar
2013-11-18 14:08 ` Santosh Shilimkar
2013-11-18 19:32 ` ivan.khoronzhuk
2013-11-18 19:32 ` ivan.khoronzhuk
2013-11-18 19:32 ` ivan.khoronzhuk
2013-11-13 5:02 ` Sekhar Nori
2013-11-13 5:02 ` Sekhar Nori
2013-11-13 5:02 ` Sekhar Nori
2013-11-13 5:02 ` Sekhar Nori
2013-11-13 14:14 ` Santosh Shilimkar
2013-11-13 14:14 ` Santosh Shilimkar
2013-11-13 14:14 ` Santosh Shilimkar
2013-11-14 10:53 ` Sekhar Nori
2013-11-14 10:53 ` Sekhar Nori
2013-11-14 10:53 ` Sekhar Nori
2013-11-14 10:53 ` Sekhar Nori
2013-11-14 14:36 ` Santosh Shilimkar
2013-11-14 14:36 ` Santosh Shilimkar
2013-11-14 14:36 ` Santosh Shilimkar
2013-11-14 14:36 ` Santosh Shilimkar
2013-11-18 19:35 ` ivan.khoronzhuk
2013-11-18 19:35 ` ivan.khoronzhuk
2013-11-18 19:35 ` ivan.khoronzhuk
2013-11-21 17:07 ` Sekhar Nori
2013-11-21 17:07 ` Sekhar Nori
2013-11-21 17:07 ` Sekhar Nori
2013-11-21 17:07 ` Sekhar Nori
2013-11-22 17:38 ` Santosh Shilimkar
2013-11-22 17:38 ` Santosh Shilimkar
2013-11-22 17:38 ` Santosh Shilimkar
2013-11-22 17:38 ` Santosh Shilimkar
2013-11-24 9:46 ` Sekhar Nori
2013-11-24 9:46 ` Sekhar Nori
2013-11-24 9:46 ` Sekhar Nori
2013-11-24 9:46 ` Sekhar Nori
2013-11-25 20:00 ` [PATCH] ARM: davinci: aemif: get rid of davinci-nand driver dependency on aemif Ivan Khoronzhuk
2013-11-25 20:00 ` Ivan Khoronzhuk
2013-11-25 20:00 ` Ivan Khoronzhuk
2013-11-25 20:00 ` Ivan Khoronzhuk
2013-11-27 8:35 ` Sekhar Nori
2013-11-27 8:35 ` Sekhar Nori
2013-11-27 8:35 ` Sekhar Nori
2013-11-27 11:01 ` ivan.khoronzhuk
2013-11-27 11:01 ` ivan.khoronzhuk
2013-11-27 11:01 ` ivan.khoronzhuk
2013-11-27 13:07 ` Sekhar Nori
2013-11-27 13:07 ` Sekhar Nori
2013-11-27 13:07 ` Sekhar Nori
2013-11-27 13:21 ` ivan.khoronzhuk
2013-11-27 13:21 ` ivan.khoronzhuk
2013-11-27 13:21 ` ivan.khoronzhuk
2013-11-26 0:55 ` [PATCH 10/12] mtd: nand: davinci: don't set timings if AEMIF is used Santosh Shilimkar
2013-11-26 0:55 ` Santosh Shilimkar
2013-11-26 0:55 ` Santosh Shilimkar
[not found] ` <1384187188-5776-12-git-send-email-ivan.khoronzhuk@ti.com>
2013-11-11 17:12 ` [PATCH 11/12] mtd: nand: davinci: don't request AEMIF address range Khoronzhuk, Ivan
2013-11-11 17:12 ` Khoronzhuk, Ivan
2013-11-11 17:12 ` Khoronzhuk, Ivan
2013-11-12 16:15 ` Santosh Shilimkar
2013-11-12 16:15 ` Santosh Shilimkar
2013-11-12 16:15 ` Santosh Shilimkar
[not found] ` <1384187188-5776-13-git-send-email-ivan.khoronzhuk@ti.com>
2013-11-11 17:13 ` [PATCH 12/12] arm: dts: keystone: add AEMIF/NAND device entry Khoronzhuk, Ivan
2013-11-11 17:13 ` Khoronzhuk, Ivan
2013-11-11 17:13 ` Khoronzhuk, Ivan
2013-11-11 17:13 ` Khoronzhuk, Ivan
2013-11-12 16:19 ` Santosh Shilimkar
2013-11-12 16:19 ` Santosh Shilimkar
2013-11-12 16:19 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52824ED9.5040104@ti.com \
--to=santosh.shilimkar@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@kernel.crashing.org \
--cc=grygorii.strashko@ti.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=ivan.khoronzhuk@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.