From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33963) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VgH3v-00027K-B9 for qemu-devel@nongnu.org; Tue, 12 Nov 2013 11:43:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VgH3q-0004sD-9f for qemu-devel@nongnu.org; Tue, 12 Nov 2013 11:43:35 -0500 Received: from mx1.redhat.com ([209.132.183.28]:1408) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VgH3q-0004rk-1v for qemu-devel@nongnu.org; Tue, 12 Nov 2013 11:43:30 -0500 Message-ID: <52825AAC.9030500@redhat.com> Date: Tue, 12 Nov 2013 09:43:24 -0700 From: Eric Blake MIME-Version: 1.0 References: <1384273995-16486-1-git-send-email-cminyard@mvista.com> <1384273995-16486-3-git-send-email-cminyard@mvista.com> In-Reply-To: <1384273995-16486-3-git-send-email-cminyard@mvista.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HF9TgEdoCLqOpqKE5uOnuEQsIgTWb2ITF" Subject: Re: [Qemu-devel] [PATCH 02/16] qemu-char: Allow a chardev to reconnect if disconnected List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Corey Minyard , qemu-devel@nongnu.org Cc: Bret Ketchum , Corey Minyard , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , "Michael S. Tsirkin" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --HF9TgEdoCLqOpqKE5uOnuEQsIgTWb2ITF Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 11/12/2013 09:33 AM, Corey Minyard wrote: > Allow a socket that connects to reconnect on a periodic basis if it > fails to connect at startup or if the connection drops while in use. >=20 > Signed-off-by: Corey Minyard > --- > include/sysemu/char.h | 3 ++ > qemu-char.c | 88 +++++++++++++++++++++++++++++++++++++++++++= +------- > qemu-options.hx | 11 +++++-- > 3 files changed, 87 insertions(+), 15 deletions(-) >=20 > +++ b/qemu-options.hx > @@ -1780,8 +1780,9 @@ ETEXI > DEF("chardev", HAS_ARG, QEMU_OPTION_chardev, > "-chardev null,id=3Did[,mux=3Don|off]\n" > "-chardev socket,id=3Did[,host=3Dhost],port=3Dhost[,to=3Dto][,ipv4= ][,ipv6][,nodelay]\n" > - " [,server][,nowait][,telnet][,mux=3Don|off] (tcp)\n" > - "-chardev socket,id=3Did,path=3Dpath[,server][,nowait][,telnet],[m= ux=3Don|off] (unix)\n" > + " [,server][,nowait][,telnet][,mux=3Don|off][,reconnect=3D= seconds] (tcp)\n" > + "-chardev socket,id=3Did,path=3Dpath[,server][,nowait][,telnet][,m= ux=3Don|off]\n" > + " [,reconnect=3Dseconds] (unix)\n" > +@option{reconnect} specifies that if the socket does not come up at st= artup, > +or if the socket is closed for some reason (like the other end exited)= , > +wait the given number of seconds and attempt to reconnect. Sounds cool. Are you planning on also adding the QMP counterpart for specifying this option when doing hotplugs of a chardev? Does reconnect make any sense when not using server mode? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --HF9TgEdoCLqOpqKE5uOnuEQsIgTWb2ITF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSglqsAAoJEKeha0olJ0NqB+sH/0oOzQyqAdzhQhMHH5tiHiVg zX4Ka1ETFTF4j9pkqT1UkppLJKRqk1FDKMpA0/QzXi08pshpRlfYqASF2AUh1jkH 86mNcVUab5B+cGsphOMJrN0dqPxquLzYR+2tGZXgKzgm1wn/CMdzN2HJV/dthdNi /jvUOLIgrW9M+UoPdAd3YgXZBKVYvQ5uPfmObcLoLElOLCMnfXh5/TRmYG6PYw2d MPRxwe4CS3i4QEmz/o0J8uXJvVjkCuMEPj7ylmI0FwHe0mWmIXBJHwo6vZSrVL1w eSjRIEuuLSYIx3S6IA3VxtfX5QfUmzzGnRjfDM1ckKB2sTG4lRJRTXxUkEUUOEk= =4kDL -----END PGP SIGNATURE----- --HF9TgEdoCLqOpqKE5uOnuEQsIgTWb2ITF--