From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41969) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VgHRp-0001CT-Eb for qemu-devel@nongnu.org; Tue, 12 Nov 2013 12:08:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VgHRj-0002Qx-55 for qemu-devel@nongnu.org; Tue, 12 Nov 2013 12:08:17 -0500 Received: from mail-ob0-f173.google.com ([209.85.214.173]:39105) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VgHRi-0002QX-W3 for qemu-devel@nongnu.org; Tue, 12 Nov 2013 12:08:11 -0500 Received: by mail-ob0-f173.google.com with SMTP id wm4so6214315obc.18 for ; Tue, 12 Nov 2013 09:08:09 -0800 (PST) Message-ID: <52826077.3090103@mvista.com> Date: Tue, 12 Nov 2013 11:08:07 -0600 From: Corey Minyard MIME-Version: 1.0 References: <1384273995-16486-1-git-send-email-cminyard@mvista.com> <1384273995-16486-3-git-send-email-cminyard@mvista.com> <52825AAC.9030500@redhat.com> In-Reply-To: <52825AAC.9030500@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 02/16] qemu-char: Allow a chardev to reconnect if disconnected List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: Bret Ketchum , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , "Michael S. Tsirkin" On 11/12/2013 10:43 AM, Eric Blake wrote: > On 11/12/2013 09:33 AM, Corey Minyard wrote: >> Allow a socket that connects to reconnect on a periodic basis if it >> fails to connect at startup or if the connection drops while in use. >> >> Signed-off-by: Corey Minyard >> --- >> include/sysemu/char.h | 3 ++ >> qemu-char.c | 88 ++++++++++++++++++++++++++++++++++++++++++++------- >> qemu-options.hx | 11 +++++-- >> 3 files changed, 87 insertions(+), 15 deletions(-) >> >> +++ b/qemu-options.hx >> @@ -1780,8 +1780,9 @@ ETEXI >> DEF("chardev", HAS_ARG, QEMU_OPTION_chardev, >> "-chardev null,id=id[,mux=on|off]\n" >> "-chardev socket,id=id[,host=host],port=host[,to=to][,ipv4][,ipv6][,nodelay]\n" >> - " [,server][,nowait][,telnet][,mux=on|off] (tcp)\n" >> - "-chardev socket,id=id,path=path[,server][,nowait][,telnet],[mux=on|off] (unix)\n" >> + " [,server][,nowait][,telnet][,mux=on|off][,reconnect=seconds] (tcp)\n" >> + "-chardev socket,id=id,path=path[,server][,nowait][,telnet][,mux=on|off]\n" >> + " [,reconnect=seconds] (unix)\n" >> +@option{reconnect} specifies that if the socket does not come up at startup, >> +or if the socket is closed for some reason (like the other end exited), >> +wait the given number of seconds and attempt to reconnect. > Sounds cool. Are you planning on also adding the QMP counterpart for > specifying this option when doing hotplugs of a chardev? Yes, I need to add that. > Does reconnect > make any sense when not using server mode? > Actually, it only really makes sense when in client mode. The option currently won't do anything in server mode. I can't see a use for it in server mode, it doesn't know where to connect. -corey