All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfststs: add a helper to get the minimum dio size
Date: Tue, 12 Nov 2013 12:32:32 -0600	[thread overview]
Message-ID: <52827440.9060603@sandeen.net> (raw)
In-Reply-To: <20131112183031.GA8106@infradead.org>

On 11/12/13, 12:30 PM, Christoph Hellwig wrote:
> On Tue, Nov 12, 2013 at 12:13:16PM -0600, Eric Sandeen wrote:
>> On 11/6/13, 4:59 AM, Christoph Hellwig wrote:
>>> Various tests opencode checks to find out the minimum support direct I/O
>>> size.  Replace those with a generic helper that handles network filesystems as
>>> well.  Also remove the Linux 2.4 workaround we had in once place.
>>>
>>> Signed-off-by: Christoph Hellwig <hch@lst.de>
>>
>> No callers of min_dio_alignment w/o a blockdev right?  But I guess
>> that fallback is harmless.
> 
> All network filesystems will not have a device here.  Not sure how the
> btrfs pool names work, but that would be another suspect.
> 

Ah, sure.  So when running on NFS the blkdev is unset.  Wasn't thinking
about it that way, thanks.

-Eric

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2013-11-12 18:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-06 10:59 [PATCH] xfststs: add a helper to get the minimum dio size Christoph Hellwig
2013-11-12 17:35 ` Christoph Hellwig
2013-11-12 18:13 ` Eric Sandeen
2013-11-12 18:30   ` Christoph Hellwig
2013-11-12 18:32     ` Eric Sandeen [this message]
2013-11-13  3:33 ` Rich Johnston

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52827440.9060603@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=hch@infradead.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.