From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Weil Subject: Re: [PATCH for-1.7] target-i386: Fix build by providing stub kvm_arch_get_supported_cpuid() Date: Tue, 12 Nov 2013 20:15:54 +0100 Message-ID: <52827E6A.7050603@weilnetz.de> References: <5281580D.7060305@redhat.com> <52816422.8060002@redhat.com> <52821A62.2050001@redhat.com> <52822958.8060508@redhat.com> <20131112132337.GB2008@redhat.com> <528233DD.6020306@redhat.com> <20131112140935.GD2008@redhat.com> <528241E0.5060503@redhat.com> <52824766.2000507@redhat.com> <52825009.10506@redhat.com> <5282794D.20108@twiddle.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: kvm-devel , Gleb Natapov , Patch Tracking , QEMU Developers , Andreas Tobler , Anthony Liguori , Paolo Bonzini , Anthony Liguori To: Peter Maydell , Richard Henderson Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org Am 12.11.2013 19:57, schrieb Peter Maydell: > On 12 November 2013 18:54, Richard Henderson wrote: >> For what it's worth, I think BOTH of the patches that have been posted >> should be applied. That is, the patch that does (X || 1) -> (1 || X), >> and the patch that adds the stub. > I think that makes sense and would be happy with that as a resolution. > > thanks > -- PMM > +1. By the way: I added a stub for kvm_arch_get_supported_cpuid() in my kvm patch, too (see http://patchwork.ozlabs.org/patch/260512/). It called g_assert_not_reached()instead of returning 0.Maybe this can be added in a later patch. Regards, Stefan From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43448) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VgJRU-0006mH-Kg for qemu-devel@nongnu.org; Tue, 12 Nov 2013 14:16:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VgJRP-000543-G6 for qemu-devel@nongnu.org; Tue, 12 Nov 2013 14:16:04 -0500 Received: from [2a03:4000:1::4e2f:c7ac:d] (port=52000 helo=v220110690675601.yourvserver.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VgJRP-00053Y-6i for qemu-devel@nongnu.org; Tue, 12 Nov 2013 14:15:59 -0500 Message-ID: <52827E6A.7050603@weilnetz.de> Date: Tue, 12 Nov 2013 20:15:54 +0100 From: Stefan Weil MIME-Version: 1.0 References: <5281580D.7060305@redhat.com> <52816422.8060002@redhat.com> <52821A62.2050001@redhat.com> <52822958.8060508@redhat.com> <20131112132337.GB2008@redhat.com> <528233DD.6020306@redhat.com> <20131112140935.GD2008@redhat.com> <528241E0.5060503@redhat.com> <52824766.2000507@redhat.com> <52825009.10506@redhat.com> <5282794D.20108@twiddle.net> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-1.7] target-i386: Fix build by providing stub kvm_arch_get_supported_cpuid() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , Richard Henderson Cc: kvm-devel , Gleb Natapov , Patch Tracking , QEMU Developers , Andreas Tobler , Anthony Liguori , Paolo Bonzini , Anthony Liguori Am 12.11.2013 19:57, schrieb Peter Maydell: > On 12 November 2013 18:54, Richard Henderson wrote: >> For what it's worth, I think BOTH of the patches that have been posted >> should be applied. That is, the patch that does (X || 1) -> (1 || X), >> and the patch that adds the stub. > I think that makes sense and would be happy with that as a resolution. > > thanks > -- PMM > +1. By the way: I added a stub for kvm_arch_get_supported_cpuid() in my kvm patch, too (see http://patchwork.ozlabs.org/patch/260512/). It called g_assert_not_reached()instead of returning 0.Maybe this can be added in a later patch. Regards, Stefan