From: Eric Blake <eblake@redhat.com>
To: Avi Kivity <avi@cloudius-systems.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] build: set up capabilities on qemu-bridge-helper
Date: Tue, 12 Nov 2013 12:23:21 -0700 [thread overview]
Message-ID: <52828029.3020501@redhat.com> (raw)
In-Reply-To: <c66f8b4405fbe3d1ad36d85392bbc556c7959774.1384254624.git.avi@cloudius-systems.com>
[-- Attachment #1: Type: text/plain, Size: 841 bytes --]
On 11/12/2013 04:10 AM, Avi Kivity wrote:
> Out-of-the-box, 'make install' sets up an unusable qemu-bridge-helper since
> it doesn't have the required capabilities.
>
> Fix by adding them.
>
> Note: this may break installing as non-root. This is actually the right
> thing to do, since not setting up the capability would result in a broken
> setup. Perhaps we need a configure flag to disable helpers.
>
> +++ b/rules.mak
> @@ -177,3 +177,5 @@ $(shell mkdir -p $(sort $(foreach var,$(nested-vars),$(dir $($(var))))))
> $(foreach var,$(nested-vars), $(eval \
> -include $(addsuffix *.d, $(sort $(dir $($(var)))))))
> endef
> +
> +SETCAP = setcap
> \ No newline at end of file
Is this intentional?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-11-12 19:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-12 11:10 [Qemu-devel] [PATCH] build: set up capabilities on qemu-bridge-helper Avi Kivity
2013-11-12 19:23 ` Eric Blake [this message]
2013-11-12 19:27 ` Avi Kivity
2013-11-14 13:29 ` Stefan Hajnoczi
2013-11-14 14:39 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52828029.3020501@redhat.com \
--to=eblake@redhat.com \
--cc=avi@cloudius-systems.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.