Re: [PATCH 2/2] optee-ftpm: rewrite its optee-os bbappend to use EARLY_TA_PATHS bitbake variable

[Jan Kiszka <jan.kiszka@siemens.com>]

On 04.09.26 11:36, Rasmus Villemoes wrote:
> On Thu, Aug 27 2026, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> 
>> On 27.08.26 15:37, Rasmus Villemoes wrote:
>>> From: Rasmus Villemoes <ravi@prevas.dk>
>>>
>>> If anything else in the BSP also wants or needs to add an early TA to
>>> optee, that will conflict with this .bbappend adding its own
>>> EARLY_TA_PATHS="..." argument to EXTRA_OEMAKE.
>>>
>>> Instead, add the path to the ftpm TA to the newly introduced
>>> EARLY_TA_PATHS bitbake variable, which the main recipe will use to
>>> produce the make argument.
>>>
>>> Passing CFG_EARLY_TA=y explicitly is not needed, as optee-os' build
>>> system sets that automatically if the EARLY_TA_PATHS list is
>>> non-empty.
>>>
>>> CFG_CORE_HEAP_SIZE is somewhat harder to make play along nicely with
>>> other .bbappends that might have an opinion on its proper (minimum)
>>> value. For now, keep adding it explicitly to EXTRA_OEMAKE.
>>>
>>> Signed-off-by: Rasmus Villemoes <ravi@prevas.dk>
>>> ---
>>>  .../recipes-security/optee-ftpm/optee-os_%.bbappend    | 10 +++++-----
>>>  1 file changed, 5 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/meta-arm/recipes-security/optee-ftpm/optee-os_%.bbappend b/meta-arm/recipes-security/optee-ftpm/optee-os_%.bbappend
>>> index 92c11157..74bde25e 100644
>>> --- a/meta-arm/recipes-security/optee-ftpm/optee-os_%.bbappend
>>> +++ b/meta-arm/recipes-security/optee-ftpm/optee-os_%.bbappend
>>> @@ -4,8 +4,8 @@ DEPENDS:append = "\
>>>      ${@bb.utils.contains('MACHINE_FEATURES', 'optee-ftpm', 'optee-ftpm', '' , d)} \
>>>  "
>>>  
>>> -EXTRA_OEMAKE:append = "\
>>> -    ${@bb.utils.contains('MACHINE_FEATURES', 'optee-ftpm', \
>>> -        'CFG_CORE_HEAP_SIZE=131072 CFG_EARLY_TA=y EARLY_TA_PATHS="${STAGING_DIR_TARGET}/${base_libdir}/optee_armtz/${FTPM_UUID}.stripped.elf"', \
>>> -        '', d)} \
>>> -"
>>> +python() {
>>> +    if bb.utils.contains('MACHINE_FEATURES', 'optee-ftpm', True, False, d):
>>> +        d.appendVar('EARLY_TA_PATHS', ' ${STAGING_DIR_TARGET}/${base_libdir}/optee_armtz/${FTPM_UUID}.stripped.elf')
>>> +        d.appendVar('EXTRA_OEMAKE', ' CFG_CORE_HEAP_SIZE=131072')
>>> +}
>>
>> Both patches look good to me, but I currently have no nothing in place 
>> to test.
> 
> Thanks. I have tested locally that the resulting op-tee works as
> expected with this refactoring, and inspected the run.do_compile scripts
> to see that they are sensible.
> 
> Anything more I need to do on my end to get these merged? And when that
> is done, are they eligible for backporting to wrynose if I then resend
> with [wrynose] in $subject?
> 

I'm not the maintainer here :)

Jan

-- 
Siemens AG, Foundational Technologies
Linux Expert Center