From: Joe Mario <jmario@redhat.com>
To: Andi Kleen <ak@linux.intel.com>, Michal Marek <mmarek@suse.cz>
Cc: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
Don Zickus <dzickus@redhat.com>
Subject: Re: [PATCH 2/2] kallsyms: Revert back to 128 max symbol length
Date: Tue, 12 Nov 2013 16:55:46 -0500 [thread overview]
Message-ID: <5282A3E2.30103@redhat.com> (raw)
In-Reply-To: <20131111141715.GM1962@tassilo.jf.intel.com>
On 11/11/2013 09:17 AM, Andi Kleen wrote:
> On Mon, Nov 11, 2013 at 02:40:36PM +0100, Michal Marek wrote:
>> This reverts commits
>> f3462aa (Kbuild: Handle longer symbols in kallsyms.c) and
>> eea0e9c (kbuild: Increase kallsyms max symbol length)
>> except for the added overflow check. The reason is a regression caused
>> by increasing the buffer:
>> http://marc.info/?l=linux-kernel&m=138387700415675.
>
> Can you please wait a bit until we tracked down the problem?
>
>
> -Andi
>
Andi:
Don Zickus and I have been trying to reproduce the problem with
the config file Fengguang Wu sent to us, but so far have been unsuccessful.
Given there are 5 other locations in the code that need to be changed
from [128] to [KSYM_NAME_LEN], and that we still haven't found Fengguang's
problem yet, I'd be in favor of letting Michal's revert patch 2/2 go forward.
That would give us time to find the issue Fengguang reported.
Joe
next prev parent reply other threads:[~2013-11-12 21:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-11 13:40 [PATCH 1/2] PCI: Do not use PCI ID macros in quirk names Michal Marek
2013-11-11 13:40 ` [PATCH 2/2] kallsyms: Revert back to 128 max symbol length Michal Marek
2013-11-11 14:17 ` Andi Kleen
2013-11-11 17:02 ` Michal Marek
2013-11-12 21:55 ` Joe Mario [this message]
2013-11-13 15:12 ` Michal Marek
2013-11-12 8:40 ` [PATCH 1/2] PCI: Do not use PCI ID macros in quirk names Michal Marek
2013-11-25 22:18 ` Bjorn Helgaas
2013-11-25 23:02 ` Andi Kleen
2013-11-25 23:06 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5282A3E2.30103@redhat.com \
--to=jmario@redhat.com \
--cc=ak@linux.intel.com \
--cc=dzickus@redhat.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.