From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <528307F0.6000805@ti.com> Date: Wed, 13 Nov 2013 10:32:40 +0530 From: Sekhar Nori MIME-Version: 1.0 To: "Khoronzhuk, Ivan" , "Shilimkar, Santosh" , Rob Landley , Russell King Subject: Re: [PATCH 10/12] mtd: nand: davinci: don't set timings if AEMIF is used References: <1384187188-5776-1-git-send-email-ivan.khoronzhuk@ti.com>, <1384187188-5776-11-git-send-email-ivan.khoronzhuk@ti.com> <4F5844B3A985794BA902E12C070812375F8D53@DNCE04.ent.ti.com> In-Reply-To: <4F5844B3A985794BA902E12C070812375F8D53@DNCE04.ent.ti.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: Mark Rutland , "devicetree@vger.kernel.org" , "Strashko, Grygorii" , Pawel Moll , Ian Campbell , Stephen Warren , Kumar Gala , Rob Herring , "linux-kernel@vger.kernel.org" , "linux-mtd@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Monday 11 November 2013 10:40 PM, Khoronzhuk, Ivan wrote: > If Davinci AEMIF is used we don't need to set timings and bus width. > It is done by AEMIF driver (drivers/memory/davinci-aemfi.c). > > Signed-off-by: Ivan Khoronzhuk > --- > drivers/mtd/nand/davinci_nand.c | 22 +++++++++++++++------- > 1 file changed, 15 insertions(+), 7 deletions(-) > > diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd/nand/davinci_nand.c > index 4705214..879e915 100644 > --- a/drivers/mtd/nand/davinci_nand.c > +++ b/drivers/mtd/nand/davinci_nand.c > @@ -742,27 +742,35 @@ static int __init nand_davinci_probe(struct platform_device *pdev) > goto err_clk_enable; > } > > +#if !IS_ENABLED(CONFIG_TI_DAVINCI_AEMIF) This is a hack! Just because AEMIF driver is enabled, it does not guarantee that the timings have been setup by it. Instead of configuring timings in two drivers, why not just convert everyone over to use the new driver. Dont worry about breaking old platforms, I will help test and ack them. Thanks, Sekhar From mboxrd@z Thu Jan 1 00:00:00 1970 From: nsekhar@ti.com (Sekhar Nori) Date: Wed, 13 Nov 2013 10:32:40 +0530 Subject: [PATCH 10/12] mtd: nand: davinci: don't set timings if AEMIF is used In-Reply-To: <4F5844B3A985794BA902E12C070812375F8D53@DNCE04.ent.ti.com> References: <1384187188-5776-1-git-send-email-ivan.khoronzhuk@ti.com>, <1384187188-5776-11-git-send-email-ivan.khoronzhuk@ti.com> <4F5844B3A985794BA902E12C070812375F8D53@DNCE04.ent.ti.com> Message-ID: <528307F0.6000805@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Monday 11 November 2013 10:40 PM, Khoronzhuk, Ivan wrote: > If Davinci AEMIF is used we don't need to set timings and bus width. > It is done by AEMIF driver (drivers/memory/davinci-aemfi.c). > > Signed-off-by: Ivan Khoronzhuk > --- > drivers/mtd/nand/davinci_nand.c | 22 +++++++++++++++------- > 1 file changed, 15 insertions(+), 7 deletions(-) > > diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd/nand/davinci_nand.c > index 4705214..879e915 100644 > --- a/drivers/mtd/nand/davinci_nand.c > +++ b/drivers/mtd/nand/davinci_nand.c > @@ -742,27 +742,35 @@ static int __init nand_davinci_probe(struct platform_device *pdev) > goto err_clk_enable; > } > > +#if !IS_ENABLED(CONFIG_TI_DAVINCI_AEMIF) This is a hack! Just because AEMIF driver is enabled, it does not guarantee that the timings have been setup by it. Instead of configuring timings in two drivers, why not just convert everyone over to use the new driver. Dont worry about breaking old platforms, I will help test and ack them. Thanks, Sekhar From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sekhar Nori Subject: Re: [PATCH 10/12] mtd: nand: davinci: don't set timings if AEMIF is used Date: Wed, 13 Nov 2013 10:32:40 +0530 Message-ID: <528307F0.6000805@ti.com> References: <1384187188-5776-1-git-send-email-ivan.khoronzhuk@ti.com>, <1384187188-5776-11-git-send-email-ivan.khoronzhuk@ti.com> <4F5844B3A985794BA902E12C070812375F8D53@DNCE04.ent.ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4F5844B3A985794BA902E12C070812375F8D53-bXo5r3zvlxeIQmiDNMet8wC/G2K4zDHf@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Khoronzhuk, Ivan" , "Shilimkar, Santosh" , Rob Landley , Russell King Cc: Mark Rutland , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "Strashko, Grygorii" , Pawel Moll , Stephen Warren , Ian Campbell , Kumar Gala , Rob Herring , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: devicetree@vger.kernel.org On Monday 11 November 2013 10:40 PM, Khoronzhuk, Ivan wrote: > If Davinci AEMIF is used we don't need to set timings and bus width. > It is done by AEMIF driver (drivers/memory/davinci-aemfi.c). > > Signed-off-by: Ivan Khoronzhuk > --- > drivers/mtd/nand/davinci_nand.c | 22 +++++++++++++++------- > 1 file changed, 15 insertions(+), 7 deletions(-) > > diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd/nand/davinci_nand.c > index 4705214..879e915 100644 > --- a/drivers/mtd/nand/davinci_nand.c > +++ b/drivers/mtd/nand/davinci_nand.c > @@ -742,27 +742,35 @@ static int __init nand_davinci_probe(struct platform_device *pdev) > goto err_clk_enable; > } > > +#if !IS_ENABLED(CONFIG_TI_DAVINCI_AEMIF) This is a hack! Just because AEMIF driver is enabled, it does not guarantee that the timings have been setup by it. Instead of configuring timings in two drivers, why not just convert everyone over to use the new driver. Dont worry about breaking old platforms, I will help test and ack them. Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751460Ab3KMFEE (ORCPT ); Wed, 13 Nov 2013 00:04:04 -0500 Received: from bear.ext.ti.com ([192.94.94.41]:46477 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750899Ab3KMFDz (ORCPT ); Wed, 13 Nov 2013 00:03:55 -0500 Message-ID: <528307F0.6000805@ti.com> Date: Wed, 13 Nov 2013 10:32:40 +0530 From: Sekhar Nori User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: "Khoronzhuk, Ivan" , "Shilimkar, Santosh" , Rob Landley , Russell King CC: Mark Rutland , "devicetree@vger.kernel.org" , "Strashko, Grygorii" , Pawel Moll , Stephen Warren , Ian Campbell , Kumar Gala , Rob Herring , "linux-kernel@vger.kernel.org" , "linux-mtd@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH 10/12] mtd: nand: davinci: don't set timings if AEMIF is used References: <1384187188-5776-1-git-send-email-ivan.khoronzhuk@ti.com>, <1384187188-5776-11-git-send-email-ivan.khoronzhuk@ti.com> <4F5844B3A985794BA902E12C070812375F8D53@DNCE04.ent.ti.com> In-Reply-To: <4F5844B3A985794BA902E12C070812375F8D53@DNCE04.ent.ti.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 11 November 2013 10:40 PM, Khoronzhuk, Ivan wrote: > If Davinci AEMIF is used we don't need to set timings and bus width. > It is done by AEMIF driver (drivers/memory/davinci-aemfi.c). > > Signed-off-by: Ivan Khoronzhuk > --- > drivers/mtd/nand/davinci_nand.c | 22 +++++++++++++++------- > 1 file changed, 15 insertions(+), 7 deletions(-) > > diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd/nand/davinci_nand.c > index 4705214..879e915 100644 > --- a/drivers/mtd/nand/davinci_nand.c > +++ b/drivers/mtd/nand/davinci_nand.c > @@ -742,27 +742,35 @@ static int __init nand_davinci_probe(struct platform_device *pdev) > goto err_clk_enable; > } > > +#if !IS_ENABLED(CONFIG_TI_DAVINCI_AEMIF) This is a hack! Just because AEMIF driver is enabled, it does not guarantee that the timings have been setup by it. Instead of configuring timings in two drivers, why not just convert everyone over to use the new driver. Dont worry about breaking old platforms, I will help test and ack them. Thanks, Sekhar