All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin ESTRABAUD <be@mpstor.com>
To: Linux-RAID <linux-raid@vger.kernel.org>
Subject: mdadm --fail requires writeable drive.
Date: Wed, 13 Nov 2013 12:17:21 +0000	[thread overview]
Message-ID: <52836DD1.8080605@mpstor.com> (raw)

Hi,

I noticed that mdadm --fail will only work if a disk is present and is 
writeable.

mdadm's Manage.c seems to first make sure the drive can be "stat"ed 
before proceeding (which will fail if the drive is gone), and then 
seemingly try to write "Faulty" to the drive's superblock as well as 
notifying MD of the drive failure.

However, in many cases, a drive must be set faulty because it has gone 
offline. MD will do a very good job to set the drive faulty itself, 
provided that IOs are running on the array. If no IOs are running on the 
array, removing a drive and then trying to set it as failed will not 
work. Trying to "-r" the drive will also fail since the drive is not yet 
marked as failed, so deemed still in use.

Looking through the code it seemed to me that MD could be told to fail a 
drive even if that drive was no longer present (the /dev/sdX device node 
file still is in this case), in the same way as remove works. Would that 
be possible? Am I missing something here?

Thanks in advance for your help.

Regards,

Ben - MPSTOR

             reply	other threads:[~2013-11-13 12:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-13 12:17 Benjamin ESTRABAUD [this message]
2013-11-14  0:44 ` mdadm --fail requires writeable drive NeilBrown
2013-11-14 17:33   ` Benjamin ESTRABAUD
2013-11-15  4:46     ` NeilBrown
2013-11-15 12:22       ` Benjamin ESTRABAUD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52836DD1.8080605@mpstor.com \
    --to=be@mpstor.com \
    --cc=linux-raid@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.