From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: xen-devel@lists.xenproject.org, Keir Fraser <keir@xen.org>,
stefano.stabellini@eu.citrix.com, tim@xen.org,
patches@linaro.org
Subject: Re: [PATCH] xen/arm: Don't call init_domheap_page with an empty range
Date: Wed, 13 Nov 2013 12:59:05 +0000 [thread overview]
Message-ID: <52837799.8050704@linaro.org> (raw)
In-Reply-To: <1384339550.5406.47.camel@kazak.uk.xensource.com>
On 11/13/2013 10:45 AM, Ian Campbell wrote:
> On Tue, 2013-11-12 at 21:42 +0000, Julien Grall wrote:
>> When an initrd is given to xen by U-boot, it will reserve the memory in
>> the device tree.
>> In this case, when xen decides to free unused memory, dt_unreserved_regions
>> will call init_domheap_page with the start and the end of range equals. But
>> the latter assumes that (start > end), if not Xen will hang because the
>> number of pages is equals to (unsigned)-1.
>
> init_xenheap_pages starts with "if (pe<=ps) return". I think
> init_domheap_pages usefully do the same.
Actually, init_domheap_pages doesn't contain this fix. I will rework
this patch to move the check in this function.
--
Julien Grall
next prev parent reply other threads:[~2013-11-13 13:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-12 21:42 [PATCH] xen/arm: Don't call init_domheap_page with an empty range Julien Grall
2013-11-13 10:45 ` Ian Campbell
2013-11-13 12:59 ` Julien Grall [this message]
2013-11-13 13:09 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52837799.8050704@linaro.org \
--to=julien.grall@linaro.org \
--cc=Ian.Campbell@citrix.com \
--cc=keir@xen.org \
--cc=patches@linaro.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.