From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: arm-uboot: misc.S:56: Error: r13 not allowed here -- `sub sp, fp, #4'
Date: Wed, 13 Nov 2013 16:15:53 +0100 [thread overview]
Message-ID: <528397A9.5020406@gmail.com> (raw)
In-Reply-To: <20131113144919.GB30137@riva.ucam.org>
[-- Attachment #1.1: Type: text/plain, Size: 2350 bytes --]
On 13.11.2013 15:49, Colin Watson wrote:
> After my previous fix, arm-uboot still fails to build with:
>
> arm-linux-gnueabihf-gcc -DHAVE_CONFIG_H -I. -I../../../grub-core -I.. -Wall -W -I../../../include -I../include -DGRUB_MACHINE_UBOOT=1 -DGRUB_MACHINE_ARM=1 -DGRUB_MACHINE=ARM_UBOOT -DGRUB_TARGET_CPU_ARM=1 -nostdinc -isystem /usr/lib/gcc-cross/arm-linux-gnueabihf/4.8/include -DGRUB_FILE=\"lib/arg.c\" -I. -I../../../grub-core -I.. -I../../.. -I../../../include -I../include -I../../../grub-core/lib/libgcrypt-grub/include -I../../../grub-core/lib/libgcrypt-grub/src/ -DGRUB_KERNEL=1 -Os -Wall -W -Wshadow -Wold-style-definition -Wpointer-arith -Wundef -Wextra -Wattributes -Wchar-subscripts -Wcomment -Wdeprecated-declarations -Wdisabled-optimization -Wdiv-by-zero -Wendif-labels -Wfloat-equal -Wformat-extra-args -Wformat-security -Wformat-y2k -Wimplicit -Wimplicit-function-declaration -Wimplicit-int -Winit-self -Wint-to-pointer-cast -Winvalid-pch -Wmain -Wmissing-braces -Wmissing-field-initializers -Wmissing-format-attribute -Wmultichar -Wnonnull -Woverflow -Wparentheses -Wpointer-ar
ith -Wpointer-to-int-cast -Wreturn-type -Wsequence-point -Wshadow -Wsign-compare -Wstrict-aliasing -Wswitch -Wtrigraphs -Wundef -Wunknown-pragmas -Wunused -Wunused-function -Wunused-label -Wunused-parameter -Wunused-value -Wunused-variable -Wvariadic-macros -Wvolatile-register-var -Wwrite-strings -Wnested-externs -Wstrict-prototypes -Wpointer-sign -g -Wredundant-decls -Wmissing-prototypes -Wmissing-declarations -Wcast-align -freg-struct-return -fno-dwarf2-cfi-asm -fno-asynchronous-unwind-tables -fno-stack-protector -mno-unaligned-access -Wtrampolines -Werror -DUSE_ASCII_FALLBACK=1 -DHAVE_UNIFONT_WIDTHSPEC=1 -mthumb-interwork -mlong-calls -ffreestanding -MT lib/kernel_exec-arg.o -MD -MP -MF lib/.deps-core/kernel_exec-arg.Tpo -c -o lib/kernel_exec-arg.o `test -f 'lib/arg.c' || echo '../../../grub-core/'`lib/arg.c
> misc.S: Assembler messages:
> misc.S:56: Error: r13 not allowed here -- `sub sp,fp,#4'
> make[3]: *** [kern/arm/kernel_exec-misc.o] Error 1
>
> I don't think SP can be used that way in Thumb mode?
>
I think that our asm routines should be in full ARM. Attached patch
follows this strategy. One remaining problem is to make sure that thumb
flags in TARGET_CFLAGS and TARGET_CCASFLAGS match.
[-- Attachment #1.2: arm.diff --]
[-- Type: application/x-patch, Size: 6427 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 291 bytes --]
next prev parent reply other threads:[~2013-11-13 15:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 14:49 arm-uboot: misc.S:56: Error: r13 not allowed here -- `sub sp,fp,#4' Colin Watson
2013-11-13 15:15 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2013-11-13 15:36 ` arm-uboot: misc.S:56: Error: r13 not allowed here -- `sub sp, fp, #4' Leif Lindholm
2013-11-13 15:45 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-11-13 16:05 ` Leif Lindholm
2013-11-14 0:24 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-11-14 10:45 ` Leif Lindholm
2013-11-13 15:22 ` arm-uboot: misc.S:56: Error: r13 not allowed here -- `sub sp,fp,#4' Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528397A9.5020406@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.