From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35120) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vgfj5-0000wk-Vg for qemu-devel@nongnu.org; Wed, 13 Nov 2013 14:03:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vgfj1-0008Oo-2P for qemu-devel@nongnu.org; Wed, 13 Nov 2013 14:03:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:9721) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vgfj0-0008Oi-Qo for qemu-devel@nongnu.org; Wed, 13 Nov 2013 14:03:39 -0500 Message-ID: <5283CCF8.7050904@redhat.com> Date: Wed, 13 Nov 2013 12:03:20 -0700 From: Eric Blake MIME-Version: 1.0 References: <1384271389-20716-1-git-send-email-pbonzini@redhat.com> <1384271389-20716-6-git-send-email-pbonzini@redhat.com> In-Reply-To: <1384271389-20716-6-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Sj76SAwclBsKgtlj0SGb1gW9SOKofJtAi" Subject: Re: [Qemu-devel] [PATCH 05/11] scsi-disk: reject ANCHOR=1 for UNMAP and WRITE SAME commands List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: kwolf@redhat.com, pl@kamp.de, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Sj76SAwclBsKgtlj0SGb1gW9SOKofJtAi Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 11/12/2013 08:49 AM, Paolo Bonzini wrote: > Since we report ANC_SUP=3D=3D0 in VPD page B2h, we need to return > an error (ILLEGAL REQUEST/INVALID FIELD IN CDB) for all WRITE SAME > requests with ANCHOR=3D=3D1. >=20 > Inspired by a similar patch to the LIO in-kernel target. >=20 > Signed-off-by: Paolo Bonzini > --- > @@ -1856,8 +1865,9 @@ static int32_t scsi_disk_emulate_command(SCSIRequ= est *req, uint8_t *buf) > =20 > /* > * We only support WRITE SAME with the unmap bit set for now. > + * Reject UNMAP=3D0 or ANCHOR=3D1. TAB damage. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Sj76SAwclBsKgtlj0SGb1gW9SOKofJtAi Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSg8z4AAoJEKeha0olJ0NqhL4IAJ/OxXWRI4FS3Fx9C0qphVQ7 rwr3ETDoaLIJfjXMVN9SCwHmrlfiV/GMSydHGeAPUdMu1pmWHvr4Jky9sIpkoO6n lVQmtixmpw6330BTiLTZkzpksIEkHK8aJAPz4NfPSgmZ84ZvQtt6u2k8UKZJpctI TYW6ZSVrOrqWQIaGWfRYPlED6tJy2bvATRsF5ilhCOlZWpodyYea8l/CQ6lnA7OI VIk9GlZmfxjriLufNfa8UBEuRkOAG0CrsvqpSPF7Gq9+RaDJRZ+8Z7Ny+5Oa44i9 tSqF2kZmS/+wwg6Dp/Nk6RdiGmYIRMOqnJPE3gmSRJi/U+HVb58ZBl037TFMfaQ= =1yZK -----END PGP SIGNATURE----- --Sj76SAwclBsKgtlj0SGb1gW9SOKofJtAi--