Re: [PATCH] x86: intel-mid: add test module for sfi_device()

[David Cohen <david.a.cohen@linux.intel.com>]

On 11/13/2013 11:29 AM, David Cohen wrote:
> This patch adds a test module to validate sfi_device() when used from a
> driver module.
>
> Signed-off-by: David Cohen <david.a.cohen@linux.intel.com>
> ---
>
> Hi Ingo and Christoph,
>
> Does this test module make sense to you?
> This could be the 4th patch of this series.
>
> Br, David
>
> ---
>   arch/x86/Kconfig                                   |  9 +++++
>   arch/x86/platform/intel-mid/device_libs/Makefile   |  2 ++
>   .../intel-mid/device_libs/platform_sfi_test.c      | 42 ++++++++++++++++++++++
>   3 files changed, 53 insertions(+)
>   create mode 100644 arch/x86/platform/intel-mid/device_libs/platform_sfi_test.c
>
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index c5f3414e453d..0b55a7742b65 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -457,6 +457,15 @@ config X86_INTEL_MID
>   	  systems which do not have the PCI legacy interfaces (Moorestown,
>   	  Medfield). If you are building for a PC class system say N here.
>
> +config SFI_TEST_MODULE
> +	tristate "Intel MID sfi test module"
> +	depends on SFI && X86_INTEL_MID && m
> +	---help---
> +	  Select to build a test module to validate SFI devices on Intel MID
> +	  platforms from driver modules.
> +
> +	  This module will be called platform_sfi_test.ko
> +
>   config X86_INTEL_LPSS
>   	bool "Intel Low Power Subsystem Support"
>   	depends on ACPI
> diff --git a/arch/x86/platform/intel-mid/device_libs/Makefile b/arch/x86/platform/intel-mid/device_libs/Makefile
> index 097e7a7940d8..b4e858e5c6e9 100644
> --- a/arch/x86/platform/intel-mid/device_libs/Makefile
> +++ b/arch/x86/platform/intel-mid/device_libs/Makefile
> @@ -20,3 +20,5 @@ obj-$(subst m,y,$(CONFIG_DRM_MEDFIELD)) += platform_tc35876x.o
>   obj-$(subst m,y,$(CONFIG_SERIAL_MRST_MAX3110)) += platform_max3111.o
>   # MISC Devices
>   obj-$(subst m,y,$(CONFIG_KEYBOARD_GPIO)) += platform_gpio_keys.o
> +# Test
> +obj-$(CONFIG_SFI_TEST_MODULE) += platform_sfi_test.o
> diff --git a/arch/x86/platform/intel-mid/device_libs/platform_sfi_test.c b/arch/x86/platform/intel-mid/device_libs/platform_sfi_test.c
> new file mode 100644
> index 000000000000..79cc18461eba
> --- /dev/null
> +++ b/arch/x86/platform/intel-mid/device_libs/platform_sfi_test.c
> @@ -0,0 +1,42 @@
> +/*
> + * platform_sfi_test.c: test module for sfi_device()
> + *
> + * (C) Copyright 2013 Intel Corporation
> + * Author: David Cohen <david.a.cohen@linux.intel.com>
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License
> + * as published by the Free Software Foundation; version 2
> + * of the License.
> + */
> +
> +#include <linux/module.h>
> +#include <asm/intel-mid.h>
> +
> +/*
> + * Even though we're implementing this device_handler callback, it should
> + * never be called when loading the module because the sfi device name
> + * "I'm_not_here" won't match to any entry on sfi table.
> + *
> + * This test validates compilation of sfi_device() in modules and validates
> + * that the attempt to enumerate an sfi device as module doesn't goes bad
> + * (despite the sfi module won't be found, the code to do the match it will be
> + * used).

I missed few typos on this comment but I can fix it if this code is
fine.

Br, David

> + */
> +static void
> +sfi_test_dev_handler(struct sfi_device_table_entry *pentry, struct devs_id *dev)
> +{
> +	pr_info("%s: This is a test for sfi_device() as module\n", __func__);
> +}
> +
> +static const struct devs_id sfi_test_dev_id __initconst = {
> +	.name = "I'm_not_here",
> +	.type = SFI_DEV_TYPE_UART,
> +	.device_handler = sfi_test_dev_handler,
> +};
> +
> +sfi_device(sfi_test_dev_id);
> +
> +MODULE_AUTHOR("David Cohen <david.a.cohen@linux.intel.com>");
> +MODULE_LICENSE("GPL v2");
> +MODULE_DESCRIPTION("This module provides test for sfi_device() macro");
>