From: "H. Peter Anvin" <hpa@linux.intel.com>
To: Steven Rostedt <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2] ftrace/x86: Load ftrace_ops in parameter not the variable holding it
Date: Wed, 13 Nov 2013 13:06:33 -0800 [thread overview]
Message-ID: <5283E9D9.5070006@linux.intel.com> (raw)
In-Reply-To: <20131113152004.459787f9@gandalf.local.home>
On 11/13/2013 12:20 PM, Steven Rostedt wrote:
>
> Function tracing callbacks expect to have the ftrace_ops that registered it
> passed to them, not the address of the variable that holds the ftrace_ops
> that registered it.
>
> Use a mov instead of a lea to store the ftrace_ops into the parameter
> of the function tracing callback.
>
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
This looks like an urgent fix, am I correct?
-hpa
next prev parent reply other threads:[~2013-11-13 21:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 20:20 [PATCH v2] ftrace/x86: Load ftrace_ops in parameter not the variable holding it Steven Rostedt
2013-11-13 21:06 ` H. Peter Anvin [this message]
2013-11-13 21:17 ` Steven Rostedt
2014-01-07 18:59 ` Steven Rostedt
2013-11-14 4:07 ` Masami Hiramatsu
2014-01-09 23:49 ` [tip:x86/urgent] " tip-bot for Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5283E9D9.5070006@linux.intel.com \
--to=hpa@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.