From: Jonathan Cameron <jic23@kernel.org>
To: Peter Meerwald <pmeerw@pmeerw.net>, linux-iio@vger.kernel.org
Cc: Andi Shyti <andi@etezian.org>
Subject: Re: [PATCH v2] iio: Add Freescale MPL3115A2 pressure / temperature sensor driver
Date: Wed, 13 Nov 2013 23:00:13 +0000 [thread overview]
Message-ID: <5284047D.8080102@kernel.org> (raw)
In-Reply-To: <1384285426-16191-1-git-send-email-pmeerw@pmeerw.net>
On 11/12/13 19:43, Peter Meerwald wrote:
> I2C-controlled MEMS sensor with 20-bit pressure measurement (pascal) and
> 12-bit temperature measurement
>
> driver only exposes basic functionality, see TODO remarks
> datasheet: http://cache.freescale.com/files/sensors/doc/data_sheet/MPL3115A2.pdf
>
> v2:
> * store 20-bit value in 32-bit buffer element (instead of 24-bit)
> * zero buffer to prevent kernel data leak to userspace
> * fix mutex unlock in trigger handler (thanks Andi Shyti)
>
> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
> Cc: Andi Shyti <andi@etezian.org>
All looks good to me. I'll let it sit on the list for a few days so that
everyone else had time to comment if they wish to.
Jonathan
next prev parent reply other threads:[~2013-11-13 21:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-12 19:43 [PATCH v2] iio: Add Freescale MPL3115A2 pressure / temperature sensor driver Peter Meerwald
2013-11-13 23:00 ` Jonathan Cameron [this message]
2013-11-15 10:37 ` Andi Shyti
2013-11-17 15:17 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5284047D.8080102@kernel.org \
--to=jic23@kernel.org \
--cc=andi@etezian.org \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.