From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH v2 for-1.7] target-i386: Fix build by providing stub kvm_arch_get_supported_cpuid() Date: Thu, 14 Nov 2013 09:53:54 +0100 Message-ID: <52848FA2.7060007@redhat.com> References: <1384384147-11076-1-git-send-email-peter.maydell@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, patches@linaro.org, Richard Henderson , Andreas Tobler , Gleb Natapov , kvm@vger.kernel.org, Anthony Liguori To: Peter Maydell Return-path: Received: from mail-wg0-f41.google.com ([74.125.82.41]:60695 "EHLO mail-wg0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751896Ab3KNIx7 (ORCPT ); Thu, 14 Nov 2013 03:53:59 -0500 Received: by mail-wg0-f41.google.com with SMTP id n12so378300wgh.0 for ; Thu, 14 Nov 2013 00:53:58 -0800 (PST) In-Reply-To: <1384384147-11076-1-git-send-email-peter.maydell@linaro.org> Sender: kvm-owner@vger.kernel.org List-ID: Il 14/11/2013 00:09, Peter Maydell ha scritto: > +#ifndef __OPTIMIZE__ > +/* This function is only called inside conditionals which we > + * rely on the compiler to optimize out when CONFIG_KVM is not > + * defined. > + */ > +uint32_t kvm_arch_get_supported_cpuid(KVMState *env, uint32_t function, > + uint32_t index, int reg) > +{ > + abort(); > +} > +#endif Thanks, I'll apply this to uq/master and send a pull request. Paolo From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42317) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vgsgi-000764-Af for qemu-devel@nongnu.org; Thu, 14 Nov 2013 03:54:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VgsgZ-0006p2-Sd for qemu-devel@nongnu.org; Thu, 14 Nov 2013 03:54:08 -0500 Received: from mail-wi0-x232.google.com ([2a00:1450:400c:c05::232]:54894) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VgsgZ-0006oq-Lo for qemu-devel@nongnu.org; Thu, 14 Nov 2013 03:53:59 -0500 Received: by mail-wi0-f178.google.com with SMTP id hn6so2073029wib.17 for ; Thu, 14 Nov 2013 00:53:58 -0800 (PST) Sender: Paolo Bonzini Message-ID: <52848FA2.7060007@redhat.com> Date: Thu, 14 Nov 2013 09:53:54 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1384384147-11076-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1384384147-11076-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 for-1.7] target-i386: Fix build by providing stub kvm_arch_get_supported_cpuid() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Gleb Natapov , kvm@vger.kernel.org, patches@linaro.org, qemu-devel@nongnu.org, Andreas Tobler , Anthony Liguori , Richard Henderson Il 14/11/2013 00:09, Peter Maydell ha scritto: > +#ifndef __OPTIMIZE__ > +/* This function is only called inside conditionals which we > + * rely on the compiler to optimize out when CONFIG_KVM is not > + * defined. > + */ > +uint32_t kvm_arch_get_supported_cpuid(KVMState *env, uint32_t function, > + uint32_t index, int reg) > +{ > + abort(); > +} > +#endif Thanks, I'll apply this to uq/master and send a pull request. Paolo