From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42520) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vgshd-00083O-LD for qemu-devel@nongnu.org; Thu, 14 Nov 2013 03:55:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VgshV-0007K5-0u for qemu-devel@nongnu.org; Thu, 14 Nov 2013 03:55:05 -0500 Sender: Paolo Bonzini Message-ID: <52848FDC.4040404@redhat.com> Date: Thu, 14 Nov 2013 09:54:52 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1384155875-26999-1-git-send-email-aik@ozlabs.ru> <1384155875-26999-6-git-send-email-aik@ozlabs.ru> <5280C629.9010704@suse.de> <5282E6B5.4090802@ozlabs.ru> <52836AB8.3020409@redhat.com> <528464FB.1050009@ozlabs.ru> In-Reply-To: <528464FB.1050009@ozlabs.ru> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 5/6] bitops: add BITNR macro List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: Alexander Graf , qemu-ppc@nongnu.org, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , qemu-devel@nongnu.org Il 14/11/2013 06:51, Alexey Kardashevskiy ha scritto: >> > The wrappers are not usable where you have constant expressions as in >> > your case. So your original patch is good IMO, except for the __ at the >> > beginning of __BITNR. > > There are 2 macros, one (BITNR) uses the other (__BITNR). What would the > good name be for BITNR then? I don't know, perhaps BITNR and BITNR_? Names starting with __ or _+uppercase are reserved by the C standard. Paolo