From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: Was: Request complete reversion of XSA-60 patches
Date: Thu, 14 Nov 2013 12:43:23 +0000
Message-ID: <5284C56B.2080804@citrix.com>
References: <5283E511.6000004@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5283E511.6000004@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Xen-devel List <xen-devel@lists.xen.org>, Keir Fraser <keir@xen.org>, Jan Beulich <JBeulich@suse.com>, Tim Deegan <tim@xen.org>
List-Id: xen-devel@lists.xenproject.org

Following a long discussion with Tim, it appears that despite the AMD
codepath being changed, there appear to be no relevant side effects as a
result, which reduces my main concern with the series.

However, in the process we identified more areas which need a cache flush.

vmx_ctxt_switch_from() needs a wbinvd() for the case where we service a
vmexit but get descheduled before returning.  There are also the
previously indicated areas which also need more cache invalidation.

There is also a wider problem with cached mappings from dom0, which are
identified but not introduced by this series.  Fixing this is still an
oustanding problem, with no sensible solution being apparent.

~Andrew