From: Mugunthan V N <mugunthanvnm@ti.com>
To: Ben Hutchings <bhutchings@solarflare.com>,
David Miller <davem@davemloft.net>, Felipe Balbi <balbi@ti.com>
Cc: <netdev@vger.kernel.org>, Richard Cochran <richardcochran@gmail.com>
Subject: Re: [PATCH net 5/6] ti_cpsw: Validate hwtstamp_config completely before applying it
Date: Thu, 14 Nov 2013 18:19:27 +0530 [thread overview]
Message-ID: <5284C6D7.9010906@ti.com> (raw)
In-Reply-To: <1384390056.29151.12.camel@bwh-desktop.uk.level5networks.com>
On Thursday 14 November 2013 06:17 AM, Ben Hutchings wrote:
> cpsw_hwtstamp_ioctl() should validate all fields of hwtstamp_config,
> and the hardware version, before making any changes. Currently it
> sets the TX configuration before validating the rx_filter field
> or that the hardware supports timestamping.
>
> Also correct the error code for hardware versions that don't
> support timestamping. ENOTSUPP is used by the NFS implementation
> and is not part of userland API; we want EOPNOTSUPP (which glibc
> also calls ENOTSUP, with one 'P').
>
> Untested as I don't have a cross-compiler to hand.
>
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
> ---
Acked-by: Mugunthan V N <mugunthanvnm@gmail.com>
Regards
Mugunthan V N
next prev parent reply other threads:[~2013-11-14 12:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-14 0:39 [PATCH net 0/6] net_tstamp: Validate hwtstamp_config completely before applying it Ben Hutchings
2013-11-14 0:40 ` [PATCH net 1/6] tg3: " Ben Hutchings
2013-11-14 0:55 ` Nithin Nayak Sujir
2013-11-14 0:41 ` [PATCH net 2/6] e1000e: " Ben Hutchings
2013-11-14 16:36 ` [E1000-devel] " Jeff Kirsher
2013-11-14 0:42 ` [PATCH net 3/6] pch_gbe: " Ben Hutchings
2013-11-14 7:21 ` Richard Cochran
2013-11-14 7:27 ` Richard Cochran
2013-11-14 8:17 ` David Miller
2013-11-14 0:43 ` [PATCH net 4/6] stmmac: " Ben Hutchings
2013-11-19 5:26 ` Giuseppe CAVALLARO
2013-11-19 5:55 ` Rayagond K
2013-11-14 0:47 ` [PATCH net 5/6] ti_cpsw: " Ben Hutchings
2013-11-14 12:49 ` Mugunthan V N [this message]
2013-11-14 0:48 ` [PATCH net 6/6] ixp4xx_eth: " Ben Hutchings
2013-11-14 6:53 ` [PATCH net 0/6] net_tstamp: " David Miller
2013-11-14 13:26 ` Richard Cochran
2013-11-14 21:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5284C6D7.9010906@ti.com \
--to=mugunthanvnm@ti.com \
--cc=balbi@ti.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.