From: "Andreas Färber" <afaerber@suse.de>
To: Alexey Kardashevskiy <aik@ozlabs.ru>, qemu-devel@nongnu.org
Cc: Igor Mammedov <imammedo@redhat.com>,
qemu-ppc@nongnu.org, Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH v3 6/6] target-ppc: demonstrate new "vsx" property
Date: Thu, 14 Nov 2013 17:04:38 +0100 [thread overview]
Message-ID: <5284F496.2010504@suse.de> (raw)
In-Reply-To: <52845D80.6080902@ozlabs.ru>
Am 14.11.2013 06:20, schrieb Alexey Kardashevskiy:
> On 11/12/2013 12:31 AM, Andreas Färber wrote:
>> 2) Please move the array out of the function to just before the
>> containing function.
>
> Again, this is just to show. But. Why do you want those properties to be
> outside of the function? Less visibility is usually a good thing, no?
We used to have ->props = (...[]) {...}; and Anthony specifically
refactored it to have a static variable one level down, just before the
function assigning it. It was a scripted conversion in the context of
QOM introduction, maybe the archives will give you insight about why
exactly it was done.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
prev parent reply other threads:[~2013-11-14 16:04 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-11 7:44 [Qemu-devel] [PATCH v3 0/6] spapr: add "compat" machine option Alexey Kardashevskiy
2013-11-11 7:44 ` [Qemu-devel] [PATCH v3 1/6] cpu: add suboptions support Alexey Kardashevskiy
2013-11-30 10:10 ` Alexey Kardashevskiy
2013-11-30 11:00 ` Paolo Bonzini
2013-11-30 13:08 ` Alexey Kardashevskiy
2013-11-11 7:44 ` [Qemu-devel] [PATCH v3 2/6] target-ppc: make use of new -cpu suboptions handling Alexey Kardashevskiy
2013-11-11 7:44 ` [Qemu-devel] [PATCH v3 3/6] target-ppc: add "compat" CPU option Alexey Kardashevskiy
2013-11-11 7:44 ` [Qemu-devel] [PATCH v3 4/6] qemu-option: support +foo/-foo command line agruments Alexey Kardashevskiy
2013-11-11 12:41 ` Andreas Färber
2013-11-11 12:52 ` Jan Kiszka
2013-11-11 13:23 ` Andreas Färber
2013-11-11 14:25 ` Igor Mammedov
2013-11-11 23:49 ` Alexey Kardashevskiy
2013-11-12 9:58 ` Igor Mammedov
2013-11-12 12:39 ` Alexey Kardashevskiy
2013-11-12 12:45 ` Andreas Färber
2013-11-13 1:51 ` Alexey Kardashevskiy
2013-11-13 9:29 ` Paolo Bonzini
2013-11-12 13:11 ` Igor Mammedov
2013-11-13 2:07 ` Alexey Kardashevskiy
2013-11-13 10:38 ` Igor Mammedov
2013-11-13 9:20 ` Paolo Bonzini
2013-11-11 7:44 ` [Qemu-devel] [PATCH v3 5/6] bitops: add BITNR macro Alexey Kardashevskiy
2013-11-11 11:57 ` Andreas Färber
2013-11-11 12:09 ` Alexey Kardashevskiy
2013-11-13 2:40 ` Alexey Kardashevskiy
2013-11-13 12:04 ` Paolo Bonzini
2013-11-14 5:51 ` Alexey Kardashevskiy
2013-11-14 8:54 ` Paolo Bonzini
2013-11-11 7:44 ` [Qemu-devel] [PATCH v3 6/6] target-ppc: demonstrate new "vsx" property Alexey Kardashevskiy
2013-11-11 13:31 ` Andreas Färber
2013-11-14 5:20 ` Alexey Kardashevskiy
2013-11-14 16:04 ` Andreas Färber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5284F496.2010504@suse.de \
--to=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.