From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45627) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VgzPX-0005fv-GA for qemu-devel@nongnu.org; Thu, 14 Nov 2013 11:04:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VgzPO-0003vF-HH for qemu-devel@nongnu.org; Thu, 14 Nov 2013 11:04:51 -0500 Message-ID: <5284F496.2010504@suse.de> Date: Thu, 14 Nov 2013 17:04:38 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1384155875-26999-1-git-send-email-aik@ozlabs.ru> <1384155875-26999-7-git-send-email-aik@ozlabs.ru> <5280DC32.9030606@suse.de> <52845D80.6080902@ozlabs.ru> In-Reply-To: <52845D80.6080902@ozlabs.ru> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 6/6] target-ppc: demonstrate new "vsx" property List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy , qemu-devel@nongnu.org Cc: Igor Mammedov , qemu-ppc@nongnu.org, Alexander Graf Am 14.11.2013 06:20, schrieb Alexey Kardashevskiy: > On 11/12/2013 12:31 AM, Andreas F=C3=A4rber wrote: >> 2) Please move the array out of the function to just before the >> containing function. >=20 > Again, this is just to show. But. Why do you want those properties to b= e > outside of the function? Less visibility is usually a good thing, no? We used to have ->props =3D (...[]) {...}; and Anthony specifically refactored it to have a static variable one level down, just before the function assigning it. It was a scripted conversion in the context of QOM introduction, maybe the archives will give you insight about why exactly it was done. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg