All of lore.kernel.org
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: Mark Hatle <mark.hatle@windriver.com>,
	 openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/1] sanity.bbclass: check for validity of TMPDIR
Date: Thu, 14 Nov 2013 10:01:12 -0800	[thread overview]
Message-ID: <52850FE8.3040409@linux.intel.com> (raw)
In-Reply-To: <5284F119.8010903@windriver.com>

On 11/14/2013 07:49 AM, Mark Hatle wrote:
> On 11/14/13, 7:42 AM, Phil Blundell wrote:
>> On Thu, 2013-11-14 at 06:27 -0700, Gary Thomas wrote:
>>> Also, is "-" actually valid?  I seem to recall having problems when
>>> my build
>>> tree had the hyphen ("-") in the path.
>>
>> Paths with "-" in certainly work for me.  If there are any recipes which
>> break in that situation then we should just fix them.
>
> We found an issue with paths that -start- with a '-', there are
> apparently many places where paths are passed into various shell, and
> the initial '-' can be read as an argument identifier.
>

I think that I saw an email talking about "-D" in the TMPDIR caused some 
some recipes to pick that up as a CFLAG define and cause problems

Sau!

>> OE already has quite a range of baroque restrictions on what sort of
>> TMPDIR you are allowed to use (no nfs, no symlinks in the path, no
>> spaces in the name) and every new prohibition represents a loss in
>> usability.  This patch as proposed already forbids a whole range of
>> characters, including things like "+", and I think that disallowing "-"
>> as well would be a step too far.
>
> I don't believe Qi Chen sent it to the list, but we built path names
> with all of the special characters and tried to run builds.  The
> specific list is based on the results of those tests.  The other items
> are already broken, and we're trying to be explicit with this for end
> users.  (Note, it's really the TMPDIR that matters.. the 'build'
> directory is a lot more flexible.)
>
> --Mark
>
>> p.
>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>


  parent reply	other threads:[~2013-11-14 18:01 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-14 13:07 [PATCH 0/1] sanity.bbclass: check for validity of TMPDIR Qi.Chen
2013-11-14 13:07 ` [PATCH 1/1] " Qi.Chen
2013-11-14 13:12   ` Richard Purdie
2013-11-15  2:41     ` ChenQi
2013-11-14 13:27   ` Gary Thomas
2013-11-14 13:42     ` Phil Blundell
2013-11-14 13:50       ` Gary Thomas
2013-11-14 15:49       ` Mark Hatle
2013-11-14 16:04         ` Phil Blundell
2013-11-14 18:02           ` Mark Hatle
2013-11-14 18:01         ` Saul Wold [this message]
2013-11-15  2:49           ` ChenQi
2013-11-15  2:44 ` [PATCH 0/1] " ChenQi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52850FE8.3040409@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=mark.hatle@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.