From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Cohen Subject: Re: [PATCH 3/3] ipc: Added support for IPC interrupt mode Date: Thu, 14 Nov 2013 13:31:56 -0800 Message-ID: <5285414C.809@linux.intel.com> References: <1384373671-12814-1-git-send-email-david.a.cohen@linux.intel.com> <1384373671-12814-4-git-send-email-david.a.cohen@linux.intel.com> <20131114134842.7225c7f8@alan.etchedpixels.co.uk> <52850A12.3090900@linux.intel.com> <20131114210015.25dab122@alan.etchedpixels.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com ([192.55.52.93]:57710 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753965Ab3KNV1Z (ORCPT ); Thu, 14 Nov 2013 16:27:25 -0500 In-Reply-To: <20131114210015.25dab122@alan.etchedpixels.co.uk> Sender: platform-driver-x86-owner@vger.kernel.org List-ID: To: One Thousand Gnomes Cc: matthew.garrett@nebula.com, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, eric.ernst@linux.intel.com, Kuppuswamy Sathyanarayanan On 11/14/2013 01:00 PM, One Thousand Gnomes wrote: > On Thu, 14 Nov 2013 09:36:18 -0800 > David Cohen wrote: > >> Hi Alan, >> >> [snip] >> >>> So I think >>> >>> 1. Pass the informatio upon whether IRQ mode should be used in the >>> platform information and remove all the ifdeffery >> >> I will double check with Sathya. But in case polling mode is left for >> development purpose, make we can create a static variable to set irq >> mode or not. > > If its only for development it doesn't IMHO need to be upstream. If its > useful for debug and/or needed on real chipsets (as I believe is the case > for the older ones) then a module (and thus kernel command line) option > would be sensible yes. Looks like this patch is keeping poll mode for Lincroft support, since interrupt mode was never tested there. We're sending new version of this patch set soon. Br, David