From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Liu Date: Fri, 15 Nov 2013 12:29:48 +0800 Subject: [Cluster-devel] [PATCH 0/6] list: introduce list_last_entry_or_null() Message-ID: <5285A33C.4040808@oracle.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi Folks, This patch is trying to introduce a new list helper to retrieve the last entry or return NULL if the list is empty corresponding to it, which is inspired by Jiri Pirko's list_first_entry_or_null(). With this trivial helper, we could get a little benefit to simplify the code logic of xfs_ail_max() and make the code looks a bit more consistent with xfs_ail_min() which has already been simplified via list_first_entry_or_null(). Moreover, as a per simple grep against fs as well as driver's tree, I think there are some other places could make use of it for similar purpose, here I spread this helper over some file systems as well. Any comments are welcome! Thanks, -Jeff From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from userp1040.oracle.com ([156.151.31.81]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VhB35-0004vR-EA for linux-mtd@lists.infradead.org; Fri, 15 Nov 2013 04:30:28 +0000 Message-ID: <5285A33C.4040808@oracle.com> Date: Fri, 15 Nov 2013 12:29:48 +0800 From: Jeff Liu MIME-Version: 1.0 To: linux-kernel@vger.kernel.org Subject: [PATCH 0/6] list: introduce list_last_entry_or_null() Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: jfs-discussion@lists.sourceforge.net, jiri@resnulli.us, gregkh@linuxfoundation.org, oleg@redhat.com, "xfs@oss.sgi.com" , cluster-devel@redhat.com, linux-mtd@lists.infradead.org, akpm@linux-foundation.org List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Folks, This patch is trying to introduce a new list helper to retrieve the last entry or return NULL if the list is empty corresponding to it, which is inspired by Jiri Pirko's list_first_entry_or_null(). With this trivial helper, we could get a little benefit to simplify the code logic of xfs_ail_max() and make the code looks a bit more consistent with xfs_ail_min() which has already been simplified via list_first_entry_or_null(). Moreover, as a per simple grep against fs as well as driver's tree, I think there are some other places could make use of it for similar purpose, here I spread this helper over some file systems as well. Any comments are welcome! Thanks, -Jeff From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 1310E7F5F for ; Thu, 14 Nov 2013 22:30:39 -0600 (CST) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay1.corp.sgi.com (Postfix) with ESMTP id E5D5F8F8035 for ; Thu, 14 Nov 2013 20:30:35 -0800 (PST) Received: from userp1040.oracle.com (userp1040.oracle.com [156.151.31.81]) by cuda.sgi.com with ESMTP id QiCBA0psdTL2ZrWX (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Thu, 14 Nov 2013 20:30:34 -0800 (PST) Message-ID: <5285A33C.4040808@oracle.com> Date: Fri, 15 Nov 2013 12:29:48 +0800 From: Jeff Liu MIME-Version: 1.0 Subject: [PATCH 0/6] list: introduce list_last_entry_or_null() List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: linux-kernel@vger.kernel.org Cc: jfs-discussion@lists.sourceforge.net, jiri@resnulli.us, gregkh@linuxfoundation.org, oleg@redhat.com, "xfs@oss.sgi.com" , cluster-devel@redhat.com, linux-mtd@lists.infradead.org, akpm@linux-foundation.org Hi Folks, This patch is trying to introduce a new list helper to retrieve the last entry or return NULL if the list is empty corresponding to it, which is inspired by Jiri Pirko's list_first_entry_or_null(). With this trivial helper, we could get a little benefit to simplify the code logic of xfs_ail_max() and make the code looks a bit more consistent with xfs_ail_min() which has already been simplified via list_first_entry_or_null(). Moreover, as a per simple grep against fs as well as driver's tree, I think there are some other places could make use of it for similar purpose, here I spread this helper over some file systems as well. Any comments are welcome! Thanks, -Jeff _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756842Ab3KOEap (ORCPT ); Thu, 14 Nov 2013 23:30:45 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:42828 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755084Ab3KOEai (ORCPT ); Thu, 14 Nov 2013 23:30:38 -0500 Message-ID: <5285A33C.4040808@oracle.com> Date: Fri, 15 Nov 2013 12:29:48 +0800 From: Jeff Liu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: linux-kernel@vger.kernel.org CC: akpm@linux-foundation.org, "xfs@oss.sgi.com" , cluster-devel@redhat.com, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, oleg@redhat.com, jiri@resnulli.us, gregkh@linuxfoundation.org Subject: [PATCH 0/6] list: introduce list_last_entry_or_null() Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Source-IP: ucsinet21.oracle.com [156.151.31.93] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Folks, This patch is trying to introduce a new list helper to retrieve the last entry or return NULL if the list is empty corresponding to it, which is inspired by Jiri Pirko's list_first_entry_or_null(). With this trivial helper, we could get a little benefit to simplify the code logic of xfs_ail_max() and make the code looks a bit more consistent with xfs_ail_min() which has already been simplified via list_first_entry_or_null(). Moreover, as a per simple grep against fs as well as driver's tree, I think there are some other places could make use of it for similar purpose, here I spread this helper over some file systems as well. Any comments are welcome! Thanks, -Jeff