Re: [PATCH RESEND v5 2/6] xen/arm: Implement get_maximum_gpfn hypercall for arm

[Eugene Fedotov <e.fedotov@samsung.com>]

13.11.2013 14:58, Ian Campbell пишет:
> On Wed, 2013-11-13 at 12:28 +0400, Eugene Fedotov wrote:
>>>> diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
>>>> index 123280e..3801f07 100644
>>>> --- a/xen/arch/arm/mm.c
>>>> +++ b/xen/arch/arm/mm.c
>>>> @@ -927,7 +927,11 @@ int page_is_ram_type(unsigned long mfn, unsigned long mem_type)
>>>>    
>>>>    unsigned long domain_get_maximum_gpfn(struct domain *d)
>>> s/unsigned long/xen_pfn_t/ I think.
>>>
>>> Urk, which will break the ABI for this hypercall. That's something of a
>>> conundrum :-/
>>>
>>> It is a domctl so we are at liberty to change it, probably to taking a
>>> xen_pfn_t * to fill in instead of returning the value.
>>>
>>> I'm in two minds about whether we should do so now or postpone it (which
>>> risks forgetting and having an obscure bug somewhere down the line).
>> OK, this way, or other solution is to purge this hypercall yet in
>> migration and use max_memkb field in DOMCTL_getdomaininfo to obtain the
>> maximum PFN.
> Is there an interface to retrieve that? I don't see it :-(
No, it is another hypercall XEN_DOMCTL_getdomaininfo. max_memkb field in 
xc_dominfo_t structure is a second way to retrieve maximum memory size 
and calculate PFN. Do we need domain_get_maximum_gpfn ?

Best regards,
Evgeny.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel