From: Pierre AUBERT <p.aubert@staubli.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] hashtable: fix the export lenght computation.
Date: Fri, 15 Nov 2013 08:09:59 +0100 [thread overview]
Message-ID: <5285C8C7.80503@staubli.com> (raw)
In-Reply-To: <20131114172544.B0D55380C60@gemini.denx.de>
Dear Wolfgang Denk,
Le 14/11/2013 18:25, Wolfgang Denk a ?crit :
> Dear Pierre Aubert,
>
> In message <1384434720-11214-2-git-send-email-p.aubert@staubli.com> you wrote:
>> The room for the '=' and the sep char was reserved twice.
> Are you sure? Keep in mind that the termination of the list is a
> _double_ NUL byte. IIRC this is what we do here.
Yes, I'm sure. The termination of the list (last NULL after the last
separator) is added at line 666
> 666 size = totlen + 1;
In the actual code, the lenght is two large of 2 char for each exported
variable.
Best regards
>
> Best regards,
>
> Wolfgang Denk
>
next prev parent reply other threads:[~2013-11-15 7:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-14 13:11 [U-Boot] [PATCH 0/2] env export fixes Pierre Aubert
2013-11-14 13:11 ` [U-Boot] [PATCH 1/2] hashtable: fix the export lenght computation Pierre Aubert
2013-11-14 17:25 ` Wolfgang Denk
2013-11-15 7:09 ` Pierre AUBERT [this message]
2013-11-14 13:12 ` [U-Boot] [PATCH 2/2] env export fix: compute the CRC on the real lenght of the exported variables Pierre Aubert
2013-11-14 17:24 ` Wolfgang Denk
2013-11-15 7:20 ` Pierre AUBERT
2014-02-26 20:02 ` Tom Rini
2014-03-03 17:14 ` Pierre AUBERT
2014-03-03 17:33 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5285C8C7.80503@staubli.com \
--to=p.aubert@staubli.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.