From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v3-RESEND 06/28] libxc: ocaml: add simple
 binding for xentoollog (output only).
Date: Fri, 15 Nov 2013 11:48:22 +0000
Message-ID: <52860A06.5060506@citrix.com>
References: <1382362365-6645-1-git-send-email-rob.hoes@citrix.com>
	<1382362365-6645-7-git-send-email-rob.hoes@citrix.com>
	<1384350300.5406.114.camel@kazak.uk.xensource.com>
	<360717C0B01E6345BCBE64B758E22C2D17175A@AMSPEX01CL03.citrite.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <360717C0B01E6345BCBE64B758E22C2D17175A@AMSPEX01CL03.citrite.net>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Rob Hoes <Rob.Hoes@citrix.com>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 14/11/13 14:11, Rob Hoes wrote:
> IanC wrote:
>> On Mon, 2013-10-21 at 14:32 +0100, Rob Hoes wrote:
>>> [...]
>>> +static void stub_xtl_ocaml_vmessage(struct xentoollog_logger *logger,
>>> +	xentoollog_level level,
>>> +	int errnoval,
>>> +	const char *context,
>>> +	const char *format,
>>> +	va_list al)
>>> +{
>>> +	CAMLparam0();
>>> +	CAMLlocalN(args, 4);
>>> +	struct caml_xtl *xtl = (struct caml_xtl*)logger;
>>> +	value *func = caml_named_value(xtl->vmessage_cb) ;
>>> +	char *msg;
>>> +
>>> +	if (args == NULL)
>>> +		caml_raise_out_of_memory();
>> Coverity is rightly pointing out that an array cannot be NULL. Would you
>> mind fixing as part of the resend of the remainder of this series?
> Sure, I'll fix that.
>
> Andrew Cooper showed me another issue found by Coverity. We have a fix, which I'll submit as well.
>
> Rob

Following our bit of debugging in this area, I notice that the current
series leaves some intermediate files around.

tools/ocaml/libs/xentoollog/_xtl_levels.inc
tools/ocaml/libs/xentoollog/_xtl_levels.ml.in
tools/ocaml/libs/xentoollog/_xtl_levels.mli.in
tools/ocaml/libs/xentoollog/xentoollog.ml
tools/ocaml/libs/xentoollog/xentoollog.mli

When fixing this stuff up, do you mind also modifying
.gitignore/.hgignore for all the intermediate files creates?

~Andrew