All of lore.kernel.org
 help / color / mirror / Atom feed
From: Antti Palosaari <crope@iki.fi>
To: David Howells <dhowells@redhat.com>,
	Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: linux-media@vger.kernel.org, Jarkko Korpi <jarkko_korpi@hotmail.com>
Subject: Re: I2C transfer logs for Antti's DS3103 driver and DVBSky's DS3103 driver
Date: Fri, 15 Nov 2013 15:06:29 +0200	[thread overview]
Message-ID: <52861C55.6050307@iki.fi> (raw)
In-Reply-To: <28089.1384515232@warthog.procyon.org.uk>

On 15.11.2013 13:33, David Howells wrote:
> I think I've isolated the significant part of the demod register setup.
> Discarding the reads and sorting them in address order, I see
>
> ANTTI			DVBSKY			DIFFER?
> =======================	=======================	=======
> demod_write(22, [ac])	demod_write(22, [ac])	no
> demod_write(24, [5c])	demod_write(24, [5c])	no
> 			demod_write(25, [8a])	YES
seems to be on init table

> demod_write(29, [80])	demod_write(29, [80])	no
> demod_write(30, [08])	demod_write(30, [08])	no
> demod_write(33, [00])				YES

That is config option already. Did you set value? If yes, then there is 
driver bug. If not, then add value.

> demod_write(4d, [91])	demod_write(4d, [91])	no
> 			demod_write(56, [00])	YES

driver bug

> demod_write(61, [5549])	demod_write(61, [55])	no
> 	"	"	demod_write(62, [49])	no
> 			demod_write(76, [38])	YES

on init table

> demod_write(c3, [08])	demod_write(c3, [08])	no
> demod_write(c4, [08])	demod_write(c4, [08])	no
> demod_write(c7, [00])	demod_write(c7, [00])	no
> demod_write(c8, [06])	demod_write(c8, [06])	no
> demod_write(ea, [ff])	demod_write(ea, [ff])	no
> demod_write(fd, [46])	demod_write(fd, [06])	YES

driver bug

> demod_write(fe, [6f])	demod_write(fe, [6f])	no

Two clear driver bugs, 1 case unclear and the rest should be programmed 
earlier.

So hard code those bugs, if you already didn't, 0x33=0x99, 0x56=0x00, 
0xfd=0x46 and make test. Do that same to find out all buggy registers 
until it performs as it should.

regards
Antti

-- 
http://palosaari.fi/

  reply	other threads:[~2013-11-15 13:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-14 23:35 I2C transfer logs for Antti's DS3103 driver and DVBSky's DS3103 driver David Howells
2013-11-14 23:48 ` Antti Palosaari
2013-11-15  2:15 ` David Howells
2013-11-15 11:33 ` David Howells
2013-11-15 13:06   ` Antti Palosaari [this message]
2013-11-15 13:32     ` David Howells
2013-11-15 13:36       ` Devin Heitmueller
2013-11-15 13:54       ` Antti Palosaari
2013-11-15 14:17         ` David Howells
2013-11-15 13:56       ` David Howells
2013-11-15 13:59         ` Antti Palosaari
2013-11-15 14:25           ` David Howells
2013-11-15 14:01         ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52861C55.6050307@iki.fi \
    --to=crope@iki.fi \
    --cc=dhowells@redhat.com \
    --cc=jarkko_korpi@hotmail.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.