From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH v7] libxl: usb2 and usb3 controller support for upstream qemu Date: Fri, 15 Nov 2013 15:03:29 +0000 Message-ID: <528637C1.5050806@eu.citrix.com> References: <1381239932-4922-1-git-send-email-fabio.fantoni@m2r.biz> <5285F876.2080405@m2r.biz> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5285F876.2080405@m2r.biz> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Fabio Fantoni , Stefano Stabellini Cc: xen-devel@lists.xensource.com, Ian.Jackson@eu.citrix.com, Ian.Campbell@citrix.com List-Id: xen-devel@lists.xenproject.org On 15/11/13 10:33, Fabio Fantoni wrote: > Il 12/11/2013 13:49, Stefano Stabellini ha scritto: >> On Tue, 8 Oct 2013, Fabio Fantoni wrote: >>> Usage: usbversion=1|2|3 (default=0, no usb controller defined) >>> Specifies the type of an emulated USB bus in the guest. 1 for usb1, >>> 2 for usb2 and 3 for usb3, it is available only with upstream qemu. >>> The old usb and usbdevice parameters cannot be used with this. >>> >>> Changes from v6: >>> - now usbversion cannot be used with usb and usbdevice parameters >>> - now default is 0 (no usb controller defined) >>> Will be used only with usb redirection (from spice client) and >>> new usb passthrough (from dom0) with hotplug. >>> >>> Changes from v5: >>> changed usb2 controller qemu parameters: >>> - removed bus >>> - added multifunction on all devices >>> >>> Signed-off-by: Fabio Fantoni >> This also looks OK from the QEMU arguments POV. > > Thanks for reply, could someone review it and give approval for xen > 4.4 if possible? Anthony, You had some comments on v6 of this patch. Does it look like they've been addressed? -George