From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH v4] libxl: spice usbredirection support for upstream qemu Date: Fri, 15 Nov 2013 15:18:18 +0000 Message-ID: <52863B3A.3020602@eu.citrix.com> References: <1381502301-4047-1-git-send-email-fabio.fantoni@m2r.biz> <5285F855.3040301@m2r.biz> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5285F855.3040301@m2r.biz> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Fabio Fantoni , Stefano Stabellini Cc: anthony.perard@citrix.com, xen-devel@lists.xensource.com, Ian.Jackson@eu.citrix.com, Ian.Campbell@citrix.com List-Id: xen-devel@lists.xenproject.org On 15/11/13 10:32, Fabio Fantoni wrote: > Il 12/11/2013 13:41, Stefano Stabellini ha scritto: >> On Fri, 11 Oct 2013, Fabio Fantoni wrote: >>> Usage: spiceusbredirection=NUMBER (default=0) >>> >>> Enables spice usbredirection. Creates NUMBER usbredirection channels >>> for redirection of up to 4 usb devices from spice client to domU's >>> qemu. >>> It requires an usb controller and if not defined will automatically >>> adds >>> an usb2 controller. >>> >>> Changes from v3: >>> - fixed condition that enable usbversion if it isn't defined in >>> presence >>> of usbredirection enabled >>> >>> Changes from v2: >>> - updated for usbversion patch v7 >>> - now usbredirection cannot be used with usb and usbdevice parameters >>> - if usbversion is undefined it will creates an usb2 controller >>> >>> Changes from v1: >>> - Now can be setted the number of redirection channels. >>> - Various code improvements. >>> >>> Signed-off-by: Fabio Fantoni >> It looks correct from the QEMU arguments POV > > Thanks for reply, could someone review it and give approval for xen > 4.4 if possible? It looks like this patch depends on the usb2/3 patch you have posted separately. Having to keep track of which patch depends on what -- particularly if they have different versions, as we have here -- makes it much more difficult for maintainers to figure out what's going on; that tends to make it so that you keep getting put in the "deal with it later" bucket. If you put related changes in a patch series, it will be easier to keep track of. (See http://wiki.xenproject.org/wiki/Submitting_Xen_Patches for a description of how to do this with git send-email .) -George