From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41473) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VhMml-0000xf-Km for qemu-devel@nongnu.org; Fri, 15 Nov 2013 12:02:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VhMmc-0003Ya-K7 for qemu-devel@nongnu.org; Fri, 15 Nov 2013 12:02:23 -0500 Received: from mail-pd0-f179.google.com ([209.85.192.179]:57978) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VhMmc-0003Y4-Ep for qemu-devel@nongnu.org; Fri, 15 Nov 2013 12:02:14 -0500 Received: by mail-pd0-f179.google.com with SMTP id r10so803165pdi.10 for ; Fri, 15 Nov 2013 09:02:13 -0800 (PST) Message-ID: <5286538E.3050807@ozlabs.ru> Date: Sat, 16 Nov 2013 04:02:06 +1100 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1384492469-11881-1-git-send-email-aik@ozlabs.ru> <52863995.2070007@suse.de> In-Reply-To: <52863995.2070007@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v4] ppc: introduce CPUPPCState::cpu_dt_id and CPUState::kvm_cpu_id List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , qemu-devel@nongnu.org Cc: Alexander Graf , Bharat Bhushan , qemu-ppc@nongnu.org, Paolo Bonzini , Scott Wood , Paul Mackerras On 16.11.2013 2:11, Andreas Färber wrote: > Am 15.11.2013 06:14, schrieb Alexey Kardashevskiy: >> diff --git a/include/qom/cpu.h b/include/qom/cpu.h >> index 7739e00..52fc76d 100644 >> --- a/include/qom/cpu.h >> +++ b/include/qom/cpu.h >> @@ -197,6 +197,7 @@ struct CPUState { >> bool kvm_vcpu_dirty; >> struct KVMState *kvm_state; >> struct kvm_run *kvm_run; >> + int kvm_cpu_id; >> >> /* TODO Move common fields from CPUArchState here. */ >> int cpu_index; /* used by alpha TCG */ > > Here you are adding a field to CPUState, fine with me. (Please add a > documentation line above the struct then.) > >> diff --git a/target-ppc/cpu.h b/target-ppc/cpu.h >> index bb84767..8052f6b 100644 >> --- a/target-ppc/cpu.h >> +++ b/target-ppc/cpu.h >> @@ -1074,6 +1074,9 @@ struct CPUPPCState { >> */ >> uint8_t fit_period[4]; >> uint8_t wdt_period[4]; >> + >> + /* The CPU index used in the device tree. KVM uses this index too */ >> + int cpu_dt_id; > > But I believe I have requested a number of times not to add random > fields to CPUPPCState unless they are accessed by TCG. Please place the > new field in PowerPCCPU instead and put the description into the struct > documentation. It is accessed by xics.c which is used in TCG. Or I misinterpret the rule, do not I? -- With best regards Alexey Kardashevskiy -- icq: 52150396