Re: [PATCH RFC] gpio: Driver for SYSCON-based GPIOs

[David Cohen <david.a.cohen@linux.intel.com>]

Hi Alexander,

On 11/14/2013 10:42 PM, Alexander Shiyan wrote:
> SYSCON driver was designed for using memory areas (registers)
> that are used in several subsystems. There are systems (CPUs)
> which use bits in one register for various purposes and thus
> should be handled by various kernel subsystems. This driver
> allows you to use the individual SYSCON bits as GPIOs.
> This is RFC only yet, so I did not add DT bindings for this
> driver.
>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
>   drivers/gpio/Kconfig       |   6 ++
>   drivers/gpio/Makefile      |   1 +
>   drivers/gpio/gpio-syscon.c | 141 +++++++++++++++++++++++++++++++++++++++++++++
>   3 files changed, 148 insertions(+)
>   create mode 100644 drivers/gpio/gpio-syscon.c
>

[snip]

> +	if (of_property_read_u32(np, "gpio-syscon,offset", &priv->bit_offset))
> +		return -EINVAL;

Any reason for dropping the error code from of_property_read_u32() in
favor of fixed -EINVAL?

Br, David Cohen