From: Ding Tianhong <dthxman@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: dingtianhong@huawei.com, fubar@us.ibm.com, andy@greyhouse.net,
nikolay@redhat.com, vfalico@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH net] bonding: don't change to 802.3ad mode while ARP monitor is running
Date: Sat, 16 Nov 2013 09:52:08 +0800 [thread overview]
Message-ID: <5286CFC8.4070008@gmail.com> (raw)
In-Reply-To: <20131115.204042.1434943107870815286.davem@davemloft.net>
于 2013/11/16 9:40, David Miller 写道:
> From: Ding Tianhong <dingtianhong@huawei.com>
> Date: Fri, 15 Nov 2013 18:02:18 +0800
>
>> Because the ARP monitor is not support for 802.3ad, but We still
> ^^^^^^^
>
> "supported"
>
> No need to capitalize "We".
>
>> could change the mode to 802.3ad from ab mode while ARP monirot
> ^^^^^^^
>
> "monitor"
>
>> is running, it is incorrect.
>>
>> So add a check for 802.3ad in bonding_store_mode to fix the problem,
>> and make a micro program to simplify the code.
> What is a "micro program"?
sorry, not review the changelog yet,I will resend it and it will not be
happend again.
Regards
Ding
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2013-11-16 2:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-15 10:02 [PATCH net] bonding: don't change to 802.3ad mode while ARP monitor is running Ding Tianhong
2013-11-16 1:40 ` David Miller
2013-11-16 1:52 ` Ding Tianhong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5286CFC8.4070008@gmail.com \
--to=dthxman@gmail.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=dingtianhong@huawei.com \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@redhat.com \
--cc=vfalico@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.