Hi all,

I'm attaching fixed version for next round.

Signed-off-by: Rudolf Marek <r.marek@assembler.cz>

Just a side note. The newer ITE chips implement over/undervoltage protection 
mechanism. It makes 12V/5V pins fixed. Maybe we could detect that in the driver 
and if protection is enabled we can label/scale respective pins.

Thanks
Rudolf

>> Index: linux-3.12/Documentation/hwmon/it87
>
> It might make sense to update Kconfig as well.

Fixed


> IT8603 -> IT8603E

Fixed

> ... It only supports 16-bit fan mode ... ?

Fixed

>
>> +is not supported (value 0 of pwmX_enable).
>> +

>>    *            IT8783E/F Super I/O chip w/LPC interface
>> + *            IT8603E  Super I/O chip w/LPC interface
>
> Wonder if the chip listings should all be in order (ie IT8603E comes first).

Yes I put it first now.

>> +	if ((ctrl == 0) && (data->type != it8603)) /* Full speed */
>
> I personally dislike those unnecessary extra ( ). It always confuses me.
> Especially since it is not done elsewhere in the driver and thus inconsistent.

Sorry coding style habit I fixed that.

>> @@ -1854,7 +1927,7 @@
>>   		reg = superio_inb(IT87_SIO_GPIO3_REG);
>>   		if (sio_data->type == it8721 || sio_data->type == it8728 ||
>>   		    sio_data->type == it8771 || sio_data->type == it8772 ||
>> -		    sio_data->type == it8782) {
>> +		    sio_data->type == it8782 || sio_data->type == it8603)  {
>>   			/*
>>   			 * IT8721F/IT8758E, and IT8782F don't have VID pins
>>   			 * at all, not sure about the IT8728F and compatibles.

Whoops I reverted this chunk, it is old code.

Thanks
Rudolf