From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH] arm: fix u-boot port syscall interface va_arg handling (was Re: [PATCH] [ARM] Enable boot module for arm)
Date: Sat, 16 Nov 2013 16:31:29 +0100 [thread overview]
Message-ID: <52878FD1.3020202@gmail.com> (raw)
In-Reply-To: <20131116152327.GJ30374@rocoto.smurfnet.nu>
[-- Attachment #1: Type: text/plain, Size: 922 bytes --]
On 16.11.2013 16:23, Leif Lindholm wrote:
> On Sat, Nov 16, 2013 at 04:19:48PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
>>>> @@ -138,6 +138,7 @@ FUNCTION(grub_uboot_syscall)
>>>> mov lr, pc
>>>> ldr pc, grub_uboot_syscall_ptr
>>>> str r8, gd_backup
>>>> + str r9, gd_backup + 4
>>>>
>>>> ldr r8, transition_space
>>>> ldr lr, transition_space + 4
>>>>
>>>> Can I push this fix too?
>>>
>>> Umm, at second thought - the gd pointer(s) wouldn't be changing.
>>> So the correct fix would rather be to
>>> - str r8, gd_backup
>>> ?
>>>
>> Was this tested?
>
> Tested on Ian's qemu, with an "mmc" block device..
>
Go ahead.
> /
> Leif
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 291 bytes --]
next prev parent reply other threads:[~2013-11-16 15:32 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-21 13:20 [PATCH] [ARM] Enable boot module for arm Francesco Lavra
2013-07-25 14:36 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-07-25 14:45 ` Francesco Lavra
2013-07-25 15:04 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-07-27 3:46 ` Andrey Borzenkov
2013-07-27 4:21 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-07-27 5:19 ` Andrey Borzenkov
2013-07-27 14:44 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-07-28 16:51 ` Andrey Borzenkov
2013-07-28 18:01 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-07-28 18:18 ` Andrey Borzenkov
2013-07-28 19:01 ` Andrey Borzenkov
2013-11-15 19:13 ` Andrey Borzenkov
2013-11-16 0:45 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-11-16 12:39 ` Leif Lindholm
2013-11-16 12:49 ` [PATCH] arm: fix u-boot port syscall interface va_arg handling (was Re: [PATCH] [ARM] Enable boot module for arm) Vladimir 'φ-coder/phcoder' Serbinenko
2013-11-16 13:00 ` Leif Lindholm
2013-11-16 13:17 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-11-16 13:27 ` Andrey Borzenkov
2013-11-16 13:53 ` Leif Lindholm
2013-11-16 14:03 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-11-16 14:28 ` Leif Lindholm
2013-11-16 14:45 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-11-16 14:45 ` Leif Lindholm
2013-11-16 15:19 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-11-16 15:23 ` Leif Lindholm
2013-11-16 15:31 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2013-11-16 12:54 ` [PATCH] [ARM] Enable boot module for arm Andrey Borzenkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52878FD1.3020202@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.