From: Jamal Hadi Salim <jhs@mojatatu.com>
To: David Miller <davem@davemloft.net>, eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, ebiederm@xmission.com,
alexander.h.duyck@intel.com
Subject: Re: [PATCH ] net_sched: actions - Add default lookup
Date: Sun, 17 Nov 2013 10:46:10 -0500 [thread overview]
Message-ID: <5288E4C2.9090405@mojatatu.com> (raw)
In-Reply-To: <20131103.231729.12647956618590906.davem@davemloft.net>
On 11/03/13 23:17, David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Sun, 03 Nov 2013 23:12:32 -0500 (EST)
>
>> Right, and BUG() if we try to register and action with a NULL .lookup
>> member.
>
> I return an error, BUG() is too harsh.
>
Sorry - I was distracted, but have time now.
I wanted to fix this then send the other patches - but confused.
We are setting the default if someone registers an action with
a NULL .lookup. Why do we want to return an error?
cheers,
jamal
next prev parent reply other threads:[~2013-11-17 15:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 11:25 [PATCH ] net_sched: actions - Add default lookup Jamal Hadi Salim
2013-10-30 14:00 ` Eric Dumazet
2013-11-04 4:12 ` David Miller
2013-11-04 4:17 ` David Miller
2013-11-17 15:46 ` Jamal Hadi Salim [this message]
2013-11-17 16:23 ` Jamal Hadi Salim
2013-11-05 12:19 ` Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5288E4C2.9090405@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=alexander.h.duyck@intel.com \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.