From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37893) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ViF7N-0007d5-2D for qemu-devel@nongnu.org; Sun, 17 Nov 2013 22:03:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ViF7F-00088J-EV for qemu-devel@nongnu.org; Sun, 17 Nov 2013 22:03:16 -0500 Received: from mail-gg0-f176.google.com ([209.85.161.176]:62851) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ViF7F-00087r-AV for qemu-devel@nongnu.org; Sun, 17 Nov 2013 22:03:09 -0500 Received: by mail-gg0-f176.google.com with SMTP id u2so1916032ggn.7 for ; Sun, 17 Nov 2013 19:03:07 -0800 (PST) Message-ID: <5289835E.9040106@ozlabs.ru> Date: Mon, 18 Nov 2013 14:02:54 +1100 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1384492469-11881-1-git-send-email-aik@ozlabs.ru> <5285FA1C.2070707@redhat.com> In-Reply-To: <5285FA1C.2070707@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4] ppc: introduce CPUPPCState::cpu_dt_id and CPUState::kvm_cpu_id List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, Alexander Graf , Bharat Bhushan , Paul Mackerras , Scott Wood , qemu-ppc@nongnu.org, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= On 11/15/2013 09:40 PM, Paolo Bonzini wrote: > Il 15/11/2013 06:14, Alexey Kardashevskiy ha scritto: >> >> It does not feel that we really need CPUState::kvm_cpu_id and >> direct calling of kvm_arch_vcpu_id() would be enough. > > Indeed -- and it should be kvm_ppc_vcpu_id() since other architectures > do not need it. And ignore kvm_arch_vcpu_id() for spapr/ppc? -- Alexey