From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hannes Reinecke Subject: Re: [PATCH 04/13] libmultipath: return error numbers from sysfs_get_XXX Date: Mon, 18 Nov 2013 07:51:40 +0100 Message-ID: <5289B8FC.1010801@suse.de> References: <1384511384-27642-1-git-send-email-hare@suse.de> <1384511384-27642-5-git-send-email-hare@suse.de> Reply-To: device-mapper development Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Christophe Varoqui Cc: dm-devel@redhat.com List-Id: dm-devel.ids On 11/17/2013 06:34 PM, Christophe Varoqui wrote: > declare_sysfs_get_str(devtype); > -declare_sysfs_get_str(cutype); > declare_sysfs_get_str(vendor); > declare_sysfs_get_str(model); > declare_sysfs_get_str(rev); > = > This part seems correct, as this function is not used anywhere, but > orthogonal to the patch. > Can you confirm this slip is safe ? > = Yes. I've added the 'cutype' attribute back then when I've added multipath support for DASD, but then it turned out this attribute is not required (DASD selection relies on 'devtype'). So it's safe to remove it. Cheers, Hannes -- = Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg GF: J. Hawn, J. Guild, F. Imend=F6rffer, HRB 16746 (AG N=FCrnberg)