Re: [PATCH] VT-d: fix TLB flushing in dma_pte_clear_one()

[Andrew Cooper <andrew.cooper3@citrix.com>]

On 18/11/13 11:23, Jan Beulich wrote:
> The third parameter of __intel_iommu_iotlb_flush() is to indicate
> whether the to be flushed entry was a present one. A few lines before,
> we bailed if !dma_pte_present(*pte), so there's no need to check the
> flag here again - we can simply always pass TRUE here.
>
> This is XSA-78.
>
> Suggested-by: Cheng Yueqiang <yqcheng.2008@phdis.smu.edu.sg>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

>
> --- a/xen/drivers/passthrough/vtd/iommu.c
> +++ b/xen/drivers/passthrough/vtd/iommu.c
> @@ -646,7 +646,7 @@ static void dma_pte_clear_one(struct dom
>      iommu_flush_cache_entry(pte, sizeof(struct dma_pte));
>  
>      if ( !this_cpu(iommu_dont_flush_iotlb) )
> -        __intel_iommu_iotlb_flush(domain, addr >> PAGE_SHIFT_4K , 0, 1);
> +        __intel_iommu_iotlb_flush(domain, addr >> PAGE_SHIFT_4K, 1, 1);
>  
>      unmap_vtd_domain_page(page);
>  
>
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel