All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] libtool: Apply upstream patch to set correct linkage on
Date: Mon, 18 Nov 2013 12:31:44 +0000	[thread overview]
Message-ID: <528A08B0.10402@imgtec.com> (raw)
In-Reply-To: <1384777532-58950-1-git-send-email-Vincent.Riera@imgtec.com>

On 11/18/2013 12:25 PM, Vicente Olivert Riera wrote:
> This libtool change ensures that ld uses the right machine emulation file, which
> will allow to fix several MIPS64 n64 link failures, such as the one currently
> visible on the libiscsi package. Packages affected by this problem will have to
> use <pkg>_AUTORECONF = YES to benefit from this libtool fix, until they are
> fixed upstream.
>
> Acked-by: Markos Chandras <markos.chandras@imgtec.com>
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> ---
>   .../libtool/libtool-0001-mips64-n64-linking.patch  |   47 ++++++++++++++++++++
>   1 files changed, 47 insertions(+), 0 deletions(-)
>   create mode 100644 package/libtool/libtool-0001-mips64-n64-linking.patch
>
> diff --git a/package/libtool/libtool-0001-mips64-n64-linking.patch b/package/libtool/libtool-0001-mips64-n64-linking.patch
> new file mode 100644
> index 0000000..ef9084d
> --- /dev/null
> +++ b/package/libtool/libtool-0001-mips64-n64-linking.patch
> @@ -0,0 +1,47 @@
> +sets correct linker ABI flags on MIPS64
> +http://git.savannah.gnu.org/cgit/libtool.git/commit/?id=5f7f7d9615bf650cf99d581a33b3e18357f79951
> +
> +Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> +
> +diff -ru libtool-2.4.2.orig/libltdl/m4/libtool.m4 libtool-2.4.2/libltdl/m4/libtool.m4
> +--- libtool-2.4.2.orig/libltdl/m4/libtool.m4	2013-11-11 11:44:30.419396295 +0000
> ++++ libtool-2.4.2/libltdl/m4/libtool.m4	2013-11-11 11:44:07.055032308 +0000
> +@@ -1312,6 +1312,38 @@
> +   rm -rf conftest*
> +   ;;
> +
> ++mips64*-*linux*)
> ++  # Find out what ABI is being produced by ac_compile, and set linker
> ++  # options accordingly.
> ++  echo '[#]line '$LINENO' "configure"' > conftest.$ac_ext
> ++  if AC_TRY_EVAL(ac_compile); then
> ++    emul=elf
> ++    case `/usr/bin/file conftest.$ac_objext` in
> ++      *32-bit*)
> ++      emul="${emul}32"
> ++      ;;
> ++      *64-bit*)
> ++      emul="${emul}64"
> ++      ;;
> ++    esac
> ++    case `/usr/bin/file conftest.$ac_objext` in
> ++      *MSB*)
> ++      emul="${emul}btsmip"
> ++      ;;
> ++      *LSB*)
> ++      emul="${emul}ltsmip"
> ++      ;;
> ++    esac
> ++    case `/usr/bin/file conftest.$ac_objext` in
> ++      *N32*)
> ++      emul="${emul}n32"
> ++      ;;
> ++    esac
> ++    LD="${LD-ld} -m $emul"
> ++    fi
> ++  rm -rf conftest*
> ++  ;;
> ++
> + x86_64-*kfreebsd*-gnu|x86_64-*linux*|ppc*-*linux*|powerpc*-*linux*| \
> + s390*-*linux*|s390*-*tpf*|sparc*-*linux*)
> +   # Find out which ABI we are using.
>

The email subject should be changed to "libtool: Apply upstream patch to 
set correct linkage on MIPS64"

Could you do that before committing the patch, please? Thanks.

---
Vincent

  reply	other threads:[~2013-11-18 12:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-18 12:25 [Buildroot] [PATCH v2] libtool: Apply upstream patch to set correct linkage on Vicente Olivert Riera
2013-11-18 12:31 ` Vicente Olivert Riera [this message]
2013-11-30  8:03 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=528A08B0.10402@imgtec.com \
    --to=vincent.riera@imgtec.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.