From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lan Tianyu Subject: Re: [PATCH] cpufreq: suspend/resume governors with PM notifiers Date: Mon, 18 Nov 2013 21:37:39 +0800 Message-ID: <528A1823.8080705@intel.com> References: <0e476d16e0ae4b001f5dd4f9ac191f899095928a.1384510171.git.viresh.kumar@linaro.org> <5974906.WAPp3f3eVY@vostro.rjw.lan> <5229929.5JRiWnF6CT@vostro.rjw.lan> <5289A80B.7080808@linaro.org> <5289F29B.8050806@intel.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-pm-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Viresh Kumar Cc: "Rafael J. Wysocki" , Lists linaro-kernel , Patch Tracking , "cpufreq@vger.kernel.org" , "linux-pm@vger.kernel.org" , Linux Kernel Mailing List , Nishanth Menon , jinchoi@broadcom.com, Sebastian Capella , "Srivatsa S. Bhat" On 11/18/2013 07:01 PM, Viresh Kumar wrote: > On 18 November 2013 16:27, Lan Tianyu wrote: >> How about introducing a resume/suspend callback pointer or list(if there >> are several places that need to deal with cpu resume/suspend) in the >> struct cpu and populate it in the cpufreq_add_dev()? >> >> The suspend/resume() of cpu_subsys needs to check the callback pointer >> and run it if available. > > That's almost a new infrastructure then and looks more hackish :) The resume/suspend() must be stored in the struct driver->pm? :) > Apart from that even cpufreq would be a bit hacky as we don't really need > per-cpu callbacks.. > This maybe depends on where we want the issue to be fixed, right? The cpufreq driver also can fix the issue if we run their cpu_driver resume/suspend callback earlier. Another point, I just see cpuidle_resume() and cpuidle_pause() are called in the dpm_resume_noirq and dpm_suspend_noirq(). Not sure whether this can be applied to cpufreq. -- Best Regards Tianyu Lan