From: Brian Foster <bfoster@redhat.com>
To: xfs@oss.sgi.com
Subject: Re: [PATCH 1/2] xfs: tiny xfs_setattr_mode cleanup
Date: Mon, 18 Nov 2013 08:52:37 -0500 [thread overview]
Message-ID: <528A1BA5.7060004@redhat.com> (raw)
In-Reply-To: <20131118131040.GA21649@infradead.org>
On 11/18/2013 08:10 AM, Christoph Hellwig wrote:
> Remove the pointless tp argument, and properly align the local variable
> declarations.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> ---
Reviewed-by: Brian Foster <bfoster@redhat.com>
> fs/xfs/xfs_iops.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> Index: linux/fs/xfs/xfs_iops.c
> ===================================================================
> --- linux.orig/fs/xfs/xfs_iops.c 2013-11-14 17:58:06.612700222 +0100
> +++ linux/fs/xfs/xfs_iops.c 2013-11-18 11:54:46.083792257 +0100
> @@ -459,14 +459,12 @@ xfs_vn_getattr(
>
> static void
> xfs_setattr_mode(
> - struct xfs_trans *tp,
> struct xfs_inode *ip,
> struct iattr *iattr)
> {
> - struct inode *inode = VFS_I(ip);
> - umode_t mode = iattr->ia_mode;
> + struct inode *inode = VFS_I(ip);
> + umode_t mode = iattr->ia_mode;
>
> - ASSERT(tp);
> ASSERT(xfs_isilocked(ip, XFS_ILOCK_EXCL));
>
> ip->i_d.di_mode &= S_IFMT;
> @@ -633,7 +631,7 @@ xfs_setattr_nonsize(
> * Change file access modes.
> */
> if (mask & ATTR_MODE)
> - xfs_setattr_mode(tp, ip, iattr);
> + xfs_setattr_mode(ip, iattr);
>
> /*
> * Change file access or modified times.
> @@ -871,7 +869,7 @@ xfs_setattr_size(
> * Change file access modes.
> */
> if (mask & ATTR_MODE)
> - xfs_setattr_mode(tp, ip, iattr);
> + xfs_setattr_mode(ip, iattr);
>
> if (mask & ATTR_CTIME) {
> inode->i_ctime = iattr->ia_ctime;
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2013-11-18 13:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-18 13:10 [PATCH 1/2] xfs: tiny xfs_setattr_mode cleanup Christoph Hellwig
2013-11-18 13:10 ` [PATCH 2/2] xfs: add xfs_setattr_time Christoph Hellwig
2013-11-18 13:53 ` Brian Foster
2013-11-18 13:52 ` Brian Foster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528A1BA5.7060004@redhat.com \
--to=bfoster@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.