From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.active-venture.com ([67.228.131.205]:52910 "EHLO mail.active-venture.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751755Ab3KROcA (ORCPT ); Mon, 18 Nov 2013 09:32:00 -0500 Message-ID: <528A24DE.1010507@roeck-us.net> Date: Mon, 18 Nov 2013 06:31:58 -0800 From: Guenter Roeck MIME-Version: 1.0 To: "ivan.khoronzhuk" , Santosh Shilimkar , wim@iguana.be, nsekhar@ti.com, linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org CC: grant.likely@linaro.org, rob.herring@calxeda.com, pawel.moll@arm.com, mark.rutland@arm.com, swarren@wwwdotorg.org, galak@kernel.crashing.org, ijc+devicetree@hellion.org.uk, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: Fwd: [PATCH 1/8] watchdog: davinci: change driver to use WDT core References: <1383680783-12114-2-git-send-email-ivan.khoronzhuk@ti.com> <527A287C.2090401@ti.com> <5287D5A7.7060702@roeck-us.net> <5289FE60.2040207@ti.com> In-Reply-To: <5289FE60.2040207@ti.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org On 11/18/2013 03:47 AM, ivan.khoronzhuk wrote: >>> MODULE_LICENSE("GPL"); >>> -MODULE_ALIAS_MISCDEV(WATCHDOG_MINOR); >>> MODULE_ALIAS("platform:watchdog"); >>> >> You might want to rename the platform driver to something like >> davinci-wdt and change the MODULE_ALIAS >> accordingly. >> > > Yes, it could be changed but not in this patch. > Seems to me this would be the perfect time to change it, as you switch to use the watchdog core which permits more than one active watchdog in the system. Guenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@roeck-us.net (Guenter Roeck) Date: Mon, 18 Nov 2013 06:31:58 -0800 Subject: Fwd: [PATCH 1/8] watchdog: davinci: change driver to use WDT core In-Reply-To: <5289FE60.2040207@ti.com> References: <1383680783-12114-2-git-send-email-ivan.khoronzhuk@ti.com> <527A287C.2090401@ti.com> <5287D5A7.7060702@roeck-us.net> <5289FE60.2040207@ti.com> Message-ID: <528A24DE.1010507@roeck-us.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 11/18/2013 03:47 AM, ivan.khoronzhuk wrote: >>> MODULE_LICENSE("GPL"); >>> -MODULE_ALIAS_MISCDEV(WATCHDOG_MINOR); >>> MODULE_ALIAS("platform:watchdog"); >>> >> You might want to rename the platform driver to something like >> davinci-wdt and change the MODULE_ALIAS >> accordingly. >> > > Yes, it could be changed but not in this patch. > Seems to me this would be the perfect time to change it, as you switch to use the watchdog core which permits more than one active watchdog in the system. Guenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: Fwd: [PATCH 1/8] watchdog: davinci: change driver to use WDT core Date: Mon, 18 Nov 2013 06:31:58 -0800 Message-ID: <528A24DE.1010507@roeck-us.net> References: <1383680783-12114-2-git-send-email-ivan.khoronzhuk@ti.com> <527A287C.2090401@ti.com> <5287D5A7.7060702@roeck-us.net> <5289FE60.2040207@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5289FE60.2040207-l0cyMroinI0@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "ivan.khoronzhuk" , Santosh Shilimkar , wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org, nsekhar-l0cyMroinI0@public.gmane.org, linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org, galak-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On 11/18/2013 03:47 AM, ivan.khoronzhuk wrote: >>> MODULE_LICENSE("GPL"); >>> -MODULE_ALIAS_MISCDEV(WATCHDOG_MINOR); >>> MODULE_ALIAS("platform:watchdog"); >>> >> You might want to rename the platform driver to something like >> davinci-wdt and change the MODULE_ALIAS >> accordingly. >> > > Yes, it could be changed but not in this patch. > Seems to me this would be the perfect time to change it, as you switch to use the watchdog core which permits more than one active watchdog in the system. Guenter -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html