Re: [Qemu-devel] [PATCH] qtest: Adding -display none to new tests

["Andreas Färber" <afaerber@suse.de>]

Hi,

Am 15.11.2013 20:54, schrieb Kevin Wolf:
> Without it, you either get a window for a short time, or worse, test
> failures when 'make check' isn't run in an X session.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  tests/blockdev-test.c     | 2 +-
>  tests/qdev-monitor-test.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/blockdev-test.c b/tests/blockdev-test.c
> index c940e00..fa49e09 100644
> --- a/tests/blockdev-test.c
> +++ b/tests/blockdev-test.c
> @@ -20,7 +20,7 @@ static void test_drive_add_empty(void)
>      const char *response_return;
>  
>      /* Start with an empty drive */
> -    qtest_start("-drive if=none,id=drive0");
> +    qtest_start("-display none -drive if=none,id=drive0");
[snip]

I've been wondering: Can't we just make qtest_start prepend -display
none always, so that we don't have to remember to repeatedly add it
everywhere?

Cheers,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg